-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify Robot Window HTML Test #6755
Open
CoolSpy3
wants to merge
17
commits into
cyberbotics:develop
Choose a base branch
from
DeepBlueRobotics:fix-race-condition-in-robot-window-html-test
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Clarify Robot Window HTML Test #6755
CoolSpy3
wants to merge
17
commits into
cyberbotics:develop
from
DeepBlueRobotics:fix-race-condition-in-robot-window-html-test
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoolSpy3
added
test suite issue
Test failure in the test suite CI
test suite
Start the test suite
labels
Jan 12, 2025
CoolSpy3
changed the title
Fix race condition in robot window html test
Fix Race Condition in Robot Window HTML Test
Jan 12, 2025
CoolSpy3
force-pushed
the
fix-race-condition-in-robot-window-html-test
branch
from
January 12, 2025 18:16
41c62a6
to
1abb36a
Compare
CoolSpy3
added
test suite
Start the test suite
and removed
test suite
Start the test suite
labels
Jan 12, 2025
CoolSpy3
changed the title
Fix Race Condition in Robot Window HTML Test
Clarify Robot Window HTML Test
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a potential race condition in the
robot_window_html
test. The linked issue mentioned that this test was failing. However, more interestingly, the recent-runs of this test have been passing (since ~Dec 17). No changes were made to the develop branch during this time.My guess is that this failure was caused by the test not exiting the
wb_robot_wwi_receive_text
loop after callingwb_robot_wwi_send_text
. If the robot window returns the response quickly, it is consumed by the first loop, causing the second loop to hang indefinitely. This would explain the intermittent failures.This PR forces the loop to break after the send statement, fixing this case. This should hopefully also fix the test on 22.04.
It should be noted that, for me, the test passes normally, but fails in a headless environment (presumably due to the web browser not starting), so that could be contributing to the difficulties in the CI environment. My hope is that because the test has passed before, it should be functional here.
UPDATE: My theory appears to have been wrong. The failure still occurs here (although why it passes on develop remains a mystery. I managed to fix my local build in headless mode by switching off of the default snap install of Firefox, however, that same fix doesn't appear to work here. (In fact, the logs indicate that Firefox is not installed through snap on GitHub runners.)
UPDATE 2: Alright, it looks like a runner update was pushed at around the same time this test started passing on
develop
, so I'm going to guess that that's the culprit. However, it also appears that these changes still fail onmaster
, but pass here. Perhaps it's due to the ongoing work to makedevelop
compatible with 24.04? In any case, I've backed out most of my changes here. What remains is the following:complete_test
, which briefly led me down a rabbit hole of investigating the ROS tests. I've fixed the message to reflect the correct information.Related Issues
This pull-request fixes issue #6727.