Skip to content

Commit

Permalink
Handle remove-by-default consequences.
Browse files Browse the repository at this point in the history
  • Loading branch information
hjoliver committed Jan 14, 2025
1 parent 4fb8ba4 commit 85cd3a1
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 11 deletions.
8 changes: 4 additions & 4 deletions tests/functional/cylc-trigger/02-filter-failed/flow.cylc
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@
[[fixer]]
script = """
cylc__job__wait_cylc_message_started
cylc__job__poll_grep_workflow_log -E '1/fixable1/01:running.* \(received\)failed'
cylc__job__poll_grep_workflow_log -E '1/fixable2/01:running.* \(received\)failed'
cylc__job__poll_grep_workflow_log -E '1/fixable3/01:running.* \(received\)failed'
cylc trigger "${CYLC_WORKFLOW_ID}//1/fixable*"
cylc__job__poll_grep_workflow_log -E '1/fixable1/01.* => failed'
cylc__job__poll_grep_workflow_log -E '1/fixable2/01.* => failed'
cylc__job__poll_grep_workflow_log -E '1/fixable3/01.* => failed'
cylc trigger --flow=all "${CYLC_WORKFLOW_ID}//1/fixable*:failed"
"""
[[Z]]
script = true
Expand Down
2 changes: 1 addition & 1 deletion tests/functional/cylc-trigger/04-filter-names/flow.cylc
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
cylc__job__poll_grep_workflow_log -E '1/fixable-2a/01.* \(received\)failed'
cylc__job__poll_grep_workflow_log -E '1/fixable-2b/01.* \(received\)failed'
cylc__job__poll_grep_workflow_log -E '1/fixable-3/01.* \(received\)failed'
cylc trigger "${CYLC_WORKFLOW_ID}//" \
cylc trigger --flow=all "${CYLC_WORKFLOW_ID}//" \
'//1/FIXABLE-1' '//1/fixable-2*' '//1/fixable-3'
"""
[[loser]]
Expand Down
4 changes: 2 additions & 2 deletions tests/functional/cylc-trigger/06-already-active/flow.cylc
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
[runtime]
[[triggerer]]
script = """
cylc__job__poll_grep_workflow_log "1/triggeree/01:running"
cylc trigger "$CYLC_WORKFLOW_ID//1/triggeree"
cylc__job__poll_grep_workflow_log "1/triggeree.* => running" -E
cylc trigger --flow=all "$CYLC_WORKFLOW_ID//1/triggeree"
cylc__job__poll_grep_workflow_log \
"1/triggeree.* ignoring trigger - already active" -E
"""
Expand Down
2 changes: 1 addition & 1 deletion tests/functional/flow-triggers/04-all-past/flow.cylc
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
[[d]]
script = """
if (( $CYLC_TASK_SUBMIT_NUMBER == 1 )); then
cylc trigger {{OPT}} ${CYLC_WORKFLOW_ID}//1/a
cylc trigger --flow=all {{OPT}} ${CYLC_WORKFLOW_ID}//1/a
cylc__job__poll_grep_workflow_log -E '1/a/02:running.*succeeded'
fi
"""
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
[[c]]
script = """
if (( CYLC_TASK_SUBMIT_NUMBER == 1 )); then
cylc trigger {{OPT}} ${CYLC_WORKFLOW_ID}//1/a
cylc trigger --flow=all {{OPT}} ${CYLC_WORKFLOW_ID}//1/a
cylc__job__poll_grep_workflow_log -E '1/a/02:running.*succeeded'
fi
"""
3 changes: 2 additions & 1 deletion tests/functional/flow-triggers/09-retrigger/flow.cylc
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
script = """
cylc trigger --wait ${CYLC_WORKFLOW_ID}//1/baz
cylc__job__poll_grep_workflow_log "1/baz/01:running.*succeeded"
cylc trigger --wait ${CYLC_WORKFLOW_ID}//1/baz
# use --flow here to avoid removing the first trigger history
cylc trigger --flow=all --wait ${CYLC_WORKFLOW_ID}//1/baz
cylc__job__poll_grep_workflow_log "1/baz/02:running.*succeeded"
"""
[[baz]]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@
cylc stop "$CYLC_WORKFLOW_ID"
# Force-trigger 2/foo before shutdown. On restart it should be
# in the waiting state with the force-triggered flag set.
cylc trigger "${CYLC_WORKFLOW_ID}//2/foo"
cylc trigger --flow=all "${CYLC_WORKFLOW_ID}//2/foo"
fi
"""

0 comments on commit 85cd3a1

Please sign in to comment.