Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vim.lang from syntax #6549

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jan 10, 2025

Point users of Cylc Get Resources to the new cylc.vim plugin.

closes #5626 .

Is probably massive overkill.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Small change to peripheral script.
  • Changelog entry included if this is a change that can affect users
  • Self documenting
  • Deprecation, raised against master

@wxtim wxtim force-pushed the deprecate.vim-syntax branch from feb0752 to a97fb4f Compare January 10, 2025 10:41
Point users of Cylc Get Resources to the new cylc.vim plugin.
@wxtim wxtim force-pushed the deprecate.vim-syntax branch from a97fb4f to 3f71495 Compare January 10, 2025 10:42
@wxtim wxtim self-assigned this Jan 10, 2025
@wxtim wxtim requested a review from oliver-sanders January 10, 2025 10:43
@MetRonnie MetRonnie added this to the 8.5.0 milestone Jan 10, 2025
@wxtim wxtim added the small label Jan 10, 2025
@oliver-sanders
Copy link
Member

LGTM, the tests are failing as this file was used as a reference test (just pick a new file to test with).

I think this file may also have been used for:

  • The "build" test on GH actions.
  • Conda Forge release testing.

@wxtim
Copy link
Member Author

wxtim commented Jan 13, 2025

I think this file may also have been used for:

* The "build" test on GH actions.

Can't see any evidence of this

* Conda Forge release testing.

Looks like it's using job.sh - which is so central to Cylc that it's probably a much better choice - https://github.com/conda-forge/cylc-flow-feedstock/blob/8e01cc9c760441929cc0a54ef1ac3205b5416451/recipe/meta.yaml#L36

Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to cover that CylcError line.

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure "deprecated" is right here, as you have essentially obsoleted the file.

cylc/flow/resources.py Outdated Show resolved Hide resolved
tests/unit/test_resources.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

syntax: retire the Cylc Vim syntax file
4 participants