Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy TaskJobManager: remove unecessary workflow arg from many methods #6555

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Tidy TaskJobManager: remove unecessary workflow arg from many methods #6555

merged 1 commit into from
Jan 14, 2025

Conversation

MetRonnie
Copy link
Member

Split off from #6535

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are not needed
  • No changelog entry needed
  • No docs needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added the code refactor Large code refactors label Jan 13, 2025
@MetRonnie MetRonnie added this to the 8.5.0 milestone Jan 13, 2025
@MetRonnie MetRonnie self-assigned this Jan 13, 2025
@MetRonnie MetRonnie requested a review from wxtim January 14, 2025 16:38
hjoliver
hjoliver approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I guess it must have been used once!)

@hjoliver hjoliver merged commit 931092b into cylc:master Jan 14, 2025
27 checks passed
@MetRonnie MetRonnie deleted the tidy branch January 15, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@hjoliver hjoliver hjoliver approved these changes

@wxtim wxtim Awaiting requested review from wxtim

Assignees

@MetRonnie MetRonnie

Labels
code refactor Large code refactors
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MetRonnie @hjoliver @oliver-sanders