Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(other): display commited date instead of the pull request creation date #1417

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix(other): display commited date instead of the pull request creation date #1417

merged 1 commit into from
Jan 20, 2025

Conversation

Baraka24
Copy link
Member

@Baraka24 Baraka24 commented Jan 2, 2025 •
edited
Loading

🍰 Pullrequest

Issues

Todo

  • make an additional call to the GitHub API to check if the commit is part of a pull request and if that pull request has been merged. If the PR was merged, we use the merge date (merged_at)

@Baraka24 Baraka24 requested a review from marclaporte January 2, 2025 03:05
@Baraka24 Baraka24 force-pushed the fix-server-info-commit_date branch from fe144a8 to 0df86ee Compare January 2, 2025 03:12
@Baraka24 Baraka24 changed the title fix(server-info): display commited date instead of the pull request creation date fix(other): display commited date instead of the pull request creation date Jan 2, 2025
@marclaporte marclaporte requested a review from kroky January 2, 2025 09:12
kroky
kroky reviewed Jan 7, 2025
View reviewed changes
modules/developer/modules.php Outdated Show resolved Hide resolved
@Baraka24 Baraka24 force-pushed the fix-server-info-commit_date branch 2 times, most recently from 0fd450d to 7385a73 Compare January 17, 2025 05:21
@Baraka24 Baraka24 requested a review from kroky January 17, 2025 05:23
@Baraka24 Baraka24 force-pushed the fix-server-info-commit_date branch from 7385a73 to 4c1b97c Compare January 17, 2025 10:08
@Baraka24 Baraka24 requested a review from kroky January 17, 2025 10:13
@kroky kroky merged commit 84232a2 into cypht-org:master Jan 20, 2025
9 checks passed
@Baraka24 Baraka24 added the needsCherryPicksTo2.x To be backported to all supported branches up to 2.x label Jan 20, 2025
@marclaporte marclaporte mentioned this pull request Jan 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marclaporte marclaporte Awaiting requested review from marclaporte

@kroky kroky Awaiting requested review from kroky

Assignees
No one assigned
Labels
needsCherryPicksTo2.x To be backported to all supported branches up to 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Baraka24 @kroky