Skip to content

Commit

Permalink
Merge pull request #27 from dachcom-digital/scrummer-fix-exception-ty…
Browse files Browse the repository at this point in the history
…pe-hint

#26 Change LuceneException type-hint from Exception to Throwable
  • Loading branch information
scrummer authored Feb 12, 2024
2 parents c15a095 + ffac0d9 commit 24894cf
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
5 changes: 4 additions & 1 deletion UPGRADE.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Upgrade Notes

## 2.0.3
- [BUGFIX] Fix type-hint in LuceneException constructor to match parent Exception class [#26](https://github.com/dachcom-digital/pimcore-dynamic-search-index-provider-lucene/issues/26)

## 2.0.2
- [BUGFIX] Pass locale to lucene index in multi search context

Expand All @@ -13,4 +16,4 @@
- PHP8 return type declarations added: you may have to adjust your extensions accordingly

### New Features
- Index storage base path can be configured by using the `ds_lucene.index.base_path` which is `%kernel.project_dir%/var/bundles/DsLuceneBundle/index` by default
- Index storage base path can be configured by using the `ds_lucene.index.base_path` which is `%kernel.project_dir%/var/bundles/DsLuceneBundle/index` by default
4 changes: 2 additions & 2 deletions src/DsLuceneBundle/Exception/LuceneException.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@

final class LuceneException extends \Exception
{
public function __construct(string $message, ?\Exception $previousException = null)
public function __construct(string $message, ?\Throwable $previousException = null)
{
parent::__construct(sprintf('Lucene Exception: %s', $message), 0, $previousException);
parent::__construct(message: sprintf('Lucene Exception: %s', $message), previous: $previousException);
}
}

0 comments on commit 24894cf

Please sign in to comment.