fix: removed todo comments (#136)

* fix: removed todo comments * style: Reformatted * fix: removed todo comments * fix: removed further todo comments
dailydevops · Jan 10, 2025 · cb78da2 · cb78da2
1 parent dfd5dd6
commit cb78da2
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 16 deletions.
diff --git a/src/NetEvolve.ArchiDuct/Internals/Decompiler.cs b/src/NetEvolve.ArchiDuct/Internals/Decompiler.cs
@@ -66,8 +66,6 @@ private ModelAssembly DecompileModule(IModule module, HashSet<SourceFilter> filt
         MapTypeModels(modelAssembly, module, filters);
         SetReferences(modelAssembly);
 
-        // TODO: Add GitVersion informations
-
         return modelAssembly;
     }
 
@@ -162,7 +160,7 @@ private void MapMemberModel(ModelAssembly modelAssembly, IMember member, ModelTy
 
         if (!ModelFactory.TryGetDocumentation(member, _resolver, out var doc))
         {
-            //TODO: Include undocumented items?
+            //Include undocumented items?
         }
 
         if (
@@ -176,8 +174,8 @@ parent is ModelEnum
 
         var modelMember = ModelFactory.CreateModelMemberType(member, parent, doc, _resolver);
         MapModelMemberParameters(modelMember, member);
-        //TODO: Map TypeParameters for methods and indexers
-        //TODO: ReturnAttributes
+        //Map TypeParameters for methods and indexers
+        //ReturnAttributes
 
         _ = modelAssembly.Members.Add(modelMember);
         _ = parent.Members.Add(modelMember.Id);
@@ -213,7 +211,7 @@ private void MapTypeModel(
 
         if (ModelFactory.TryGetDocumentation(typeDefinition, _resolver, out var doc))
         {
-            //TODO: Include undocumented items?
+            //Include undocumented items?
         }
 
         if (parent is null)

diff --git a/src/NetEvolve.ArchiDuct/Models/Abstractions/ModelBase.cs b/src/NetEvolve.ArchiDuct/Models/Abstractions/ModelBase.cs
@@ -8,8 +8,6 @@
 /// </summary>
 public abstract class ModelBase
 {
-    // TODO: Add DisplayValue
-
     /// <summary>
     /// Gets the xml for the described object.
     /// </summary>

diff --git a/src/NetEvolve.ArchiDuct/Models/ModelAttribute.cs b/src/NetEvolve.ArchiDuct/Models/ModelAttribute.cs
@@ -22,8 +22,5 @@ public sealed class ModelAttribute : ModelBase
 #pragma warning disable IDE0060, RCS1163 // Remove unused parameter
     internal ModelAttribute(IAttribute attribute, ITypeDefinition typeDefinition, XElement? doc)
 #pragma warning restore IDE0060, RCS1163 // Remove unused parameter
-        : base(typeDefinition.GetIdString(), typeDefinition.Name, typeDefinition.FullName, doc)
-    {
-        // TODO: Map constructor with values
-    }
+        : base(typeDefinition.GetIdString(), typeDefinition.Name, typeDefinition.FullName, doc) { }
 }
diff --git a/...s/NetEvolve.ArchiDuct.Tests.Integration/Internals/Decompiler_ExampleFileModifier_Tests.cs b/...s/NetEvolve.ArchiDuct.Tests.Integration/Internals/Decompiler_ExampleFileModifier_Tests.cs
@@ -6,7 +6,7 @@
 public class Decompiler_ExampleFileModifier_Tests(FileModifierTypeProvider provider)
     : TestCaseBase<FileModifierTypeProvider>(
         provider,
-        // TODO: This is a workaround for the issue that CI pipeline, which is running on Linux, is failing the test.
+        // This is a workaround for the issue that CI pipeline, which is running on Linux, is failing the test.
         disableMembersCheck: !RuntimeInformation.IsOSPlatform(OSPlatform.Windows),
         disableTypesCheck: !RuntimeInformation.IsOSPlatform(OSPlatform.Windows)
     ) { }

diff --git a/tests/NetEvolve.ArchiDuct.Tests.Integration/Internals/Decompiler_SystemUri_Tests.cs b/tests/NetEvolve.ArchiDuct.Tests.Integration/Internals/Decompiler_SystemUri_Tests.cs
@@ -6,7 +6,7 @@
 public class Decompiler_SystemUri_Tests(GenericTypeProvider<System.Uri> provider)
     : TypesTestCaseGenericBase<System.Uri>(
         provider,
-        // TODO: This is a workaround for the issue that CI pipeline, which is running on Linux, is failing the test.
+        // This is a workaround for the issue that CI pipeline, which is running on Linux, is failing the test.
         disableMembersCheck: !RuntimeInformation.IsOSPlatform(OSPlatform.Windows),
         disableTypesCheck: !RuntimeInformation.IsOSPlatform(OSPlatform.Windows)
     ) { }
diff --git a/tests/NetEvolve.ArchiDuct.Tests.Integration/_internals/AssembliesTestCaseBase.cs b/tests/NetEvolve.ArchiDuct.Tests.Integration/_internals/AssembliesTestCaseBase.cs
@@ -11,7 +11,7 @@ public abstract class AssembliesTestCaseBase<TTestCase>(GenericTypeProvider<TTes
     [SkippableFact]
     public async Task Verify_Architecture()
     {
-        // TODO: This is a workaround for the issue that CI pipeline, which is running on Linux, is failing the test.
+        // This is a workaround for the issue that CI pipeline, which is running on Linux, is failing the test.
         Skip.If(IsCIExecution, "Disabled in CI for now.");
 
         var architecture = _provider.Architecture;
@@ -21,7 +21,7 @@ public async Task Verify_Architecture()
     [SkippableFact]
     public async Task Verify_Assemblies()
     {
-        // TODO: This is a workaround for the issue that CI pipeline, which is running on Linux, is failing the test.
+        // This is a workaround for the issue that CI pipeline, which is running on Linux, is failing the test.
         Skip.If(IsCIExecution, "Disabled in CI for now.");
 
         var architecture = _provider.Architecture;