Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument checking and allow multiple measures #90

Merged
merged 8 commits into from
Dec 9, 2024

Conversation

picciama
Copy link
Collaborator

@picciama picciama commented Dec 4, 2024

PR Checklist

  • This comment contains a description of changes (with reason)
  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

  • allowed more measure
  • made column name handling consistent between custom and available datasets
  • made docs a bit more clear for usage with custom datasets

Technical details

  • ensured proper checks for allowed measures depending on custom or available datasets in the precence of curve_curator or not in checp_params
  • ensure presence of provided custom dataset in the right place with the right name, given dataset_name, path_data, and curve_curator

Additional context

@github-actions github-actions bot added the bug Something isn't working label Dec 4, 2024
@picciama picciama self-assigned this Dec 4, 2024
Copy link
Contributor

@JudithBernett JudithBernett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@JudithBernett JudithBernett merged commit 3ee0361 into development Dec 9, 2024
25 checks passed
@picciama picciama deleted the fix/allow_custom_dataset_names branch January 2, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants