kostal: more debug output to get better understanding of temporal behaviour

[lewurm]

Example:

FAKE Values going to inverter
SOH%: 99% , SOC%: 52% , Voltage: 370V , Max discharge power: 5000W , Max charge power: 5000W , Max temp: 6°C , Min temp: 5°C , Max cell voltage: 3596mV , Min cell voltage: 3500mV
[28357 ms] RX (dropped): 07 63 FF 02 FF 29 5E 02 16 00
FAKE Values going to inverter
SOH%: 99% , SOC%: 52% , Voltage: 370V , Max discharge power: 5000W , Max charge power: 5000W , Max temp: 6°C , Min temp: 5°C , Max cell voltage: 3596mV , Min cell voltage: 3500mV
[29177 ms] RX (dropped): 07 63 FF 02 FF 29 5E 02 16 00
[29997 ms] RX (dropped): 07 63 FF 02 FF 29 5E 02 16 00
FAKE Values going to inverter
SOH%: 99% , SOC%: 52% , Voltage: 370V , Max discharge power: 5000W , Max charge power: 5000W , Max temp: 6°C , Min temp: 5°C , Max cell voltage: 3596mV , Min cell voltage: 3500mV
[30817 ms] RX (dropped): 07 63 FF 02 FF 29 5E 02 16 00
FAKE Values going to inverter
SOH%: 99% , SOC%: 52% , Voltage: 370V , Max discharge power: 5000W , Max charge power: 5000W , Max temp: 6°C , Min temp: 5°C , Max cell voltage: 3596mV , Min cell voltage: 3500mV
[31637 ms] RX (dropped): 07 63 FF 02 FF 29 5E 02 16 00
FAKE Values going to inverter
SOH%: 99% , SOC%: 52% , Voltage: 370V , Max discharge power: 5000W , Max charge power: 5000W , Max temp: 6°C , Min temp: 5°C , Max cell voltage: 3596mV , Min cell voltage: 3500mV
[32458 ms] RX (dropped): 07 63 FF 02 FF 29 5E 02 16 00
FAKE Values going to inverter
SOH%: 99% , SOC%: 52% , Voltage: 370V , Max discharge power: 5000W , Max charge power: 5000W , Max temp: 6°C , Min temp: 5°C , Max cell voltage: 3596mV , Min cell voltage: 3500mV
[33278 ms] RX (dropped): 07 63 FF 02 FF 29 5E 02 16 00
FAKE Values going to inverter
SOH%: 99% , SOC%: 52% , Voltage: 370V , Max discharge power: 5000W , Max charge power: 5000W , Max temp: 6°C , Min temp: 5°C , Max cell voltage: 3596mV , Min cell voltage: 3500mV
[34100 ms] RX: 09 62 FF 02 FF 29 4A 08 23 00
[34100 ms] TX: 06 E2 FF 02 FF 29 01 08 A2 43 E4 70 8A 5C B5 02 D3 01 01 05 C8 41 C2 18 01 03 59 42 01 01 01 02 05 02 A0 01 01 02 2B 00

[lewurm]

I guess we should just drop DEBUG_KOSTAL_RS485_DATA and use DEBUG_VIA_USB for everything.

[gwk1]

While we have still heavy debugging going on, i prefer keeping DEBUG_KOSTAL_RS485_DATA and DEBUG_VIA_USB separated.

But that drop dropped is good, as i just figured out, that we must replace zero bytes of RX frame before rx processing, as otherwise we don't process eg. this: if (RS485_RXFRAME[6] == 0x5E) when RXFRAME[7] is 0x00

Also rx frame length may be more than 10 bytes, as there is sent EPOCH timestamp on one frame (actually never seen that, but seen on BYD code that)

[lewurm]

But that drop dropped is good, as i just figured out, that we must replace zero bytes of RX frame before rx processing, as otherwise we don't process eg. this: if (RS485_RXFRAME[6] == 0x5E) when RXFRAME[7] is 0x00

Yes, I'm handling that in my WIP branch: https://github.com/lewurm/Battery-Emulator/blob/1df27f4444ec0cfac8822256208db3e5ff780c06/Software/src/inverter/KOSTAL-RS485.cpp#L244-L249 and https://github.com/lewurm/Battery-Emulator/blob/1df27f4444ec0cfac8822256208db3e5ff780c06/Software/src/inverter/KOSTAL-RS485.cpp#L492-L497

But I don't want to submit that change just yet, because apparently some people have success with the current state and I want to understand why by adding additional logging. I suspect that it works by chance, because we send the right answer after a timeout:

Battery-Emulator/Software/src/inverter/KOSTAL-RS485.cpp

Lines 266 to 268 in 4232da8

	if ((currentMillis - B1_last_millis) > INTERVAL_1_S) {
	send_kostal(frameB1b, 8);
	B1_delay = false;

Also rx frame length may be more than 10 bytes, as there is sent EPOCH timestamp on one frame (actually never seen that, but seen on BYD code that)

That should be covered by the dump_rs485_data_rx(" (!RX_allow)"); case, at least it would print it in several steps then. But indeed, I haven't seen it in any traces yet.

[lewurm]

@dalathegreat this has been tested on a bmw i3+kostal setup. are you fine with the non-kostal changes?

[lenvm]

@lewurm, to get this PR approved more quickly, please remove the changes that are done in the battery file Software/src/battery/BMW-I3-BATTERY.cpp, and only leave the changes related to Kostal inverter.

[dalathegreat]

@lewurm , could you use the new logging method that the rest of the code uses? That would enable easier debugging, no need for the USB cable anymore!

[lewurm]

Thanks! Please have another look @lenvm and @dalathegreat

[dalathegreat]

Approved. Hope this helps Kostal!