Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library: Replace ESPAsyncWebServer library #780

Merged
merged 3 commits into from
Jan 12, 2025

Conversation

dalathegreat
Copy link
Owner

@dalathegreat dalathegreat commented Jan 11, 2025

What

This PR replaces the me-no-dev/ESPAsyncWebServer library in favour of the more supported mathieucarbou/ESPAsyncWebServer

At the same time we replace the me-no-dev/AsyncTCP library, with the mathieucarbou/AsyncTCPsock instead.

Why

See the list of improvements in the changes in this fork section for why we should switch ESPAsyncWebserver. There are also performance gains by switching AsyncTCP over to AsyncTCPsock

How

Direct replacement of ESPAsyncWebServer library. Webserver feels faster now 🚈

@dalathegreat
Copy link
Owner Author

dalathegreat commented Jan 11, 2025

image

When spamming the board with the traditional F5-torture test, the Wifi function has significantly lower execution time
3430 us vs 1032 us

@wjcloudy wjcloudy self-requested a review January 12, 2025 20:26
Copy link
Collaborator

@wjcloudy wjcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dalathegreat dalathegreat merged commit 7f938b6 into main Jan 12, 2025
106 checks passed
@dalathegreat dalathegreat deleted the bugfix/sketch-webserver branch January 12, 2025 20:30
@dalathegreat dalathegreat restored the bugfix/sketch-webserver branch January 12, 2025 20:30
@dalathegreat dalathegreat deleted the bugfix/sketch-webserver branch January 13, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants