Tesla bugfixes

[josiahhiggs]

What

Bugs noted in Tesla to fix:
More Battery Info 0x352 displaying non mux data when it should display mux.
PCS temperatures not accurate in More Battery Info.
DEBUG data not displaying 0x2B4 HV, LV data accurately.

Why

@josiahhiggs was here

How

Added BMS352_mux = true
Revised bitwise for PCS
Revised 0x2B4 data display in DEBUG

151.000 ERROR: BMS_a035_SW_Isolation
151.000 ERROR: BMS_a036_SW_HvpHvilFault
151.000 STATUS: Contactor: CLOSED, HVIL: STATUS_OK, NegativeState: ECONOMIZED, PositiveState: ECONOMIZED, setState:
OPENING, close allowed: Yes, Pyrotest: No
151.000 Battery values: Real SOC: 90.3, Battery voltage: 353V, Battery HV current: 0A, Fully charged?: YES, LFP chemistry detected!
151.000 Cellstats, Max: 3328mV (cell 13), Min: 3324mV (cell 16), Imbalance: 4mV.
151.000 High Voltage Output Pins: 352.59 V, Low Voltage: 14.18 V, DC/DC 12V current: 4.50 A.
151.000 PCS_ambientTemp: 47.70°C, DCDC_Temp: 59.30°C, ChgPhA: 46.70°C, ChgPhB: 46.70°C, ChgPhC: 46.40°C
151.000 Values passed to the inverter:
151.000 SOC: 90.30%
151.001 Max discharge power: 60000W, Max charge power: 14550W
151.001 Max temperature: 25°C, Min temperature: 29°C

[mvgalen]

This use of indexing into an arrray has a great risk of array out-of-bounds accesses which can lead to crashes. Either and the input with 0x01, to reduce it to 0 or 1. Or, and perhaps better, define an inline function returning the string, but then as result of an if/else or switch statement.

[josiahhiggs]

Would this be acceptable option for an inline function?

inline const char* getContactorText(int index) {
    switch (index) {
        case 0: return "Open";
        case 1: return "Closed";
        default: return "Unknown";
    }
}

inline const char* getHvilStatusState(int index) {
    switch (index) {
        case 0: return "Disconnected";
        case 1: return "Connected";
        default: return "Unknown";
    }
}

inline const char* getContactorState(int index) {
    switch (index) {
        case 0: return "Inactive";
        case 1: return "Active";
        default: return "Unknown";
    }
}

inline const char* getNoYes(int index) {
    switch (index) {
        case 0: return "No";
        case 1: return "Yes";
        default: return "Unknown";
    }
}

void logStatus() {
    logging.print("STATUS: Contactor: ");
    logging.print(getContactorText(battery_contactor));  // Display what state the contactor is in
    logging.print(", HVIL: ");
    logging.print(getHvilStatusState(battery_hvil_status));
    logging.print(", NegativeState: ");
    logging.print(getContactorState(battery_packContNegativeState));
    logging.print(", PositiveState: ");
    logging.print(getContactorState(battery_packContPositiveState));
    logging.print(", setState: ");
    logging.print(getContactorState(battery_packContactorSetState));
    logging.print(", close allowed: ");
    logging.print(getNoYes(battery_packCtrsClosingAllowed));
    logging.print(", Pyrotest: ");
    logging.println(getNoYes(battery_pyroTestInProgress));
}

[mvgalen]

Yes, much better imho.

[josiahhiggs]

So this change is going to apply to the webserver as well. More of an improvement PR, I think I will work on this separately to make sure I test it on my bench. Sound good?

[mvgalen]

True, but indeed better as a separate PR.

[mvgalen]

Perhaps better to combine the println(".") below with the printf on this line %.2f A.\n");

[mvgalen]

Same for this one, just add \n to the printf string.

[mvgalen]

Will approve if you change to the inline functions and fix the end of line comments I added.

[josiahhiggs]

@mvgalen I have made the requested changes and would appreciate your review comments.

[mvgalen]

I think this is a bug, the [ ... ] should be ( ... ) since getNoYes is a function and we are now indexing the pointer to the function.