Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Make CAN events more readable #823

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

dalathegreat
Copy link
Owner

What

This PR makes the various CAN events more understandable

Why

To make troubleshooting systems easier

How

In this PR, we do a few tweaks to the CAN events;

  • All CAN events now pass the interface as the variable joining the event (can_config.xxxxx)
  • EVENT_CAN_TX_FAILURE now replaced with the more descriptive EVENT_CAN_NATIVE_TX_FAILURE
  • EVENT_CAN_RX_FAILURE now replaced with the more descriptive EVENT_CAN_BATTERY_MISSING event
  • Same for battery 2, EVENT_CAN2_RX_FAILURE becomes EVENT_CAN_BATTERY2_MISSING
  • EVENT_CAN_RX_WARNING now replaced with EVENT_CAN_CORRUPTED_WARNING
  • BMW ix/PHEV no longer throw EVENT_CAN_RX_FAILURE when values are stale. Dedicated EVENT_STALE_VALUE message added.
  • Removed EVENT_CANFD_RX_FAILURE event. FD interface now uses EVENT_CAN_BATTERY_MISSING
  • EVENT_CAN_CHARGER_MISSING event added to make it easier to find out if the charger is missing
  • MCP2515 add-on CAN is now able to throw EVENT_CAN_BUFFER_FULL incase sending starts to fail

@dalathegreat dalathegreat merged commit 8f6d583 into main Jan 27, 2025
112 checks passed
@dalathegreat
Copy link
Owner Author

Merging this since needed ASAP for troubleshooting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant