Develop #27
Draft
Develop #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, enable jest debugging
…should be cleaned up
… bypass Glimmer parser for certain features
…tations/restrictions)
…es using experimental features
…custom attributes
CAndRyan
commented
Sep 12, 2022
| const getAllOpeningTagDataRegex = /<([^>]*)\/?>/g; | ||
|
|
||
| // NOTE: this regex will identify all explicit helper calls (i.e. a mustache statement with multiple arguments) | ||
| // NOTE: this will not locate helper's that take 0 args since they cannot be distiniguished from basic mustache statements without additional context |
There was a problem hiding this comment.
TODO: is there a way to distinguish helpers that take 0 args, perhaps a manual tagging process?
CAndRyan
commented
Sep 12, 2022
| // TODO: fix this hack | ||
| // Instead of forcing formatting here, fix whatever is causing certain expressions to print with pre- or post- line breaks | ||
| // A quick search through forked-glimmer-vm (aka glimmer-engine) didn't show anything apparent in the generator/printer | ||
| export const print = (text: string): string => removeLineBreaks(text); |
There was a problem hiding this comment.
TODO: identify where extra line breaks are coming from so this formatting hack can be removed
CAndRyan
commented
Sep 12, 2022
| ); | ||
| const externalImports = externals.map((name) => Babel.importDeclaration( | ||
| [Babel.importDefaultSpecifier(Babel.identifier(name))], | ||
| Babel.stringLiteral(`./${name}`) // TODO: add support for specifying partial and/or helpers directory |
There was a problem hiding this comment.
TODO: add support for specifying partial and/or helpers directory
CAndRyan
commented
Sep 12, 2022
| expectedTemplate: '<div title="{{titleIfHelper hasTooltip tooltip}}"></div>', | ||
| expectedHelpers: [`const titleIfHelper = (hasTooltip, tooltip) => hasTooltip ? tooltip : undefined;`] | ||
| }, | ||
| // { // TODO: support multiple conditional attributes within the same block? |
There was a problem hiding this comment.
TODO: support multiple conditional attributes within the same block?
CAndRyan
commented
Sep 12, 2022
| expectedTemplate: `<div ${ATTRIBUTE_GENERATOR_HELPER_FUNCTION}="{{getDataAttributesString data prefix="data-"}}"></div>`, | ||
| expectedHelpers: [] | ||
| }, | ||
| // { // TODO: support multiple attribute generator helpers within the same opening tag? |
There was a problem hiding this comment.
TODO: support multiple attribute generator helpers within the same opening tag?
CAndRyan
commented
Sep 12, 2022
| replaceAttributeGeneratingHelpers, // NOTE: this preprocessor has a dependency on having already converted attributes that contain helpers within or around their value | ||
| ]; | ||
|
|
||
| const preProcessUnsupportedParserFeatures = (handlebarsTemplate: string):PreparedTemplate => { |
There was a problem hiding this comment.
TODO: look into proper parser support for these features, to avoid the need for flaky pre-processing
CAndRyan
commented
Sep 12, 2022
| } | ||
|
|
||
| const [_, leadingData, originalHelperName, originalHelperArg, helperChild, __, trailingData] = attributeValueData; | ||
| if (helperChild.match(containsMustacheBlockRegex)) { // TODO: support helperChild being a block statement (use recursion?) |
There was a problem hiding this comment.
// TODO: support helperChild being a block statement (use recursion?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] Add support for helpers, partials, & additional functionality -- DO NOT MERGE