Lint cleanup #902
Open
Lint cleanup #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrih
force-pushed
the
lint-cleanup
branch
2 times, most recently
from
34e2cf1 to
182c95b
Compare
vrih
force-pushed
the
lint-cleanup
branch
2 times, most recently
from
42881ea to
4273a05
Compare
Calls to LoudnessEnhancer require a minSdkVersion of 19. This sets the minimum version to KitKat (October 31 2013)
This permission can only be granted to system apps
This mostly moves single object array instantiation to use Collections.singletonList.
|
A shame that this was never merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the size of this commit. This is bringing the code up to modern Java standards and is almost entirely implementing the recommendations from
android-lint. I've tried to break this up into themed commits to make review a bit easier.I don't think there's anything too controversial in there and I'm hoping cleaning this up will make it easier to move forward and tackle things like deprecated functions.