[FEATURE] Extend configuration #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominikBucher12
commented
Feb 13, 2024
| @@ -191,7 +191,7 @@ extension RichTextCoordinator { | |||
| extension ColorRepresentable { | |||
|
|
|||
| #if iOS || os(tvOS) || os(visionOS) | |||
| static var textColor: ColorRepresentable { .label } | |||
| public static var textColor: ColorRepresentable { .label } | |||
There was a problem hiding this comment.
I think we can even keep this it is in dependent PR for themes (default text color etc.) Just a note 😅
DominikBucher12
commented
Feb 13, 2024
| @@ -45,9 +45,10 @@ final class RichTextViewComponentTests: XCTestCase { | |||
| func testSettingUpWithEmptyTextWorks() { | |||
| let string = NSAttributedString(string: "") | |||
| view.setup(with: string, format: .rtf) | |||
| view.configuration = .standard | |||
There was a problem hiding this comment.
This raises question if configuration shouldn't be passed to setup instead... This feels like API is all over the place, your thoughts @danielsaidi ?
There was a problem hiding this comment.
I'm thinking we should inject it into the environment in SwiftUI.
[Feature] Add Theme Config
|
Btw this fixes #132 😍 |
danielsaidi
approved these changes
Feb 13, 2024
|
Great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR do:
How to test it