Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hydration): use useId for dom variant #325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

baileys-li
Copy link

Summary

Next.js (and other SSR frameworks) frequently logs warnings about mismatched id attributes between the server and client.
image
To address this issue, the React team introduced the useId hook, specifically designed to prevent such mismatches.

Breaking Changes

Since useId was introduced in React 18, I updated the peer dependency to require React 18 or newer. Given that React 18 was released over two years ago, it seems reasonable for this library's new version to discontinue support for older React versions.

Checklist

  • Are all the test cases passing? (only for web version, native test failing even in master, and I change nothing for native)
  • If any new feature has been added, then are the test cases updated/added? (no new features)
  • Has the documentation been updated for the proposed change, if required? (not required)

Copy link

codesandbox bot commented Nov 11, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@baileys-li
Copy link
Author

@danilowoz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant