Skip to content

Commit

Permalink
Check for strict boolean returns
Browse files Browse the repository at this point in the history
  • Loading branch information
dansoppelsa committed Jan 27, 2020
1 parent 0ecba56 commit 5506203
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 17 deletions.
24 changes: 12 additions & 12 deletions tests/CanadianHolidaysTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public function test_it_knows_new_years_day($date, $validity)
{
$date = Carbon::parse($date);

$this->assertEquals($validity, $date->isNewYearsDay());
$this->assertSame($validity, $date->isNewYearsDay());
}

public function provideNewYearsDayData()
Expand All @@ -35,7 +35,7 @@ public function test_it_knows_easter_sunday($date, $validity)
{
$date = Carbon::parse($date);

$this->assertEquals($validity, $date->isEasterSunday());
$this->assertSame($validity, $date->isEasterSunday());
}

public function provideEasterSundayData()
Expand Down Expand Up @@ -63,7 +63,7 @@ public function test_it_knows_good_friday($date, $validity)
{
$date = Carbon::parse($date);

$this->assertEquals($validity, $date->isGoodFriday());
$this->assertSame($validity, $date->isGoodFriday());
}

public function provideGoodFridayData()
Expand Down Expand Up @@ -91,7 +91,7 @@ public function test_it_knows_family_day($date, $validity)
{
$date = Carbon::parse($date);

$this->assertEquals($validity, $date->isFamilyDay());
$this->assertSame($validity, $date->isFamilyDay());
}

public function provideFamilyDayData()
Expand All @@ -114,7 +114,7 @@ public function test_it_knows_victoria_day($date, $validity)
{
$date = Carbon::parse($date);

$this->assertEquals($validity, $date->isVictoriaDay());
$this->assertSame($validity, $date->isVictoriaDay());
}

public function provideVictoriaDayData()
Expand Down Expand Up @@ -142,7 +142,7 @@ public function test_it_knows_canada_day($date, $validity)
{
$date = Carbon::parse($date);

$this->assertEquals($validity, $date->isCanadaDay());
$this->assertSame($validity, $date->isCanadaDay());
}

public function provideCanadaDayData()
Expand All @@ -167,7 +167,7 @@ public function test_it_knows_labour_day($date, $validity)
{
$date = Carbon::parse($date);

$this->assertEquals($validity, $date->isLabourDay());
$this->assertSame($validity, $date->isLabourDay());
}

public function provideLabourDayData()
Expand All @@ -192,7 +192,7 @@ public function test_it_knows_canadian_thanksgiving($date, $validity)
{
$date = Carbon::parse($date);

$this->assertEquals($validity, $date->isCanadianThanksgiving());
$this->assertSame($validity, $date->isCanadianThanksgiving());
}

public function provideCanadianThanksgivingData()
Expand All @@ -216,7 +216,7 @@ public function test_it_knows_remembrance_day($date, $validity)
{
$date = Carbon::parse($date);

$this->assertEquals($validity, $date->isRemembranceDay());
$this->assertSame($validity, $date->isRemembranceDay());
}

public function provideRemembranceDayData()
Expand All @@ -240,7 +240,7 @@ public function test_it_knows_christmas_day($date, $validity)
{
$date = Carbon::parse($date);

$this->assertEquals($validity, $date->isChristmasDay());
$this->assertSame($validity, $date->isChristmasDay());
}

public function provideChristmasDayData()
Expand All @@ -267,7 +267,7 @@ public function test_it_knows_boxing_day($date, $validity)
{
$date = Carbon::parse($date);

$this->assertEquals($validity, $date->isBoxingDay());
$this->assertSame($validity, $date->isBoxingDay());
}

public function provideBoxingDayData()
Expand All @@ -288,7 +288,7 @@ public function test_it_knows_the_canadian_civic_holiday($date, $validity)
{
$date = Carbon::parse($date);

$this->assertEquals($validity, $date->isCivicHoliday());
$this->assertSame($validity, $date->isCivicHoliday());
}

public function provideCivicHolidayData()
Expand Down
10 changes: 5 additions & 5 deletions tests/USHolidaysTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public function test_it_knows_independence_day($date, $validity)
{
$date = Carbon::parse($date);

$this->assertEquals($validity, $date->isIndependenceDay());
$this->assertSame($validity, $date->isIndependenceDay());
}

public function provideIndependenceDayData()
Expand All @@ -58,7 +58,7 @@ public function test_it_knows_memorial_day($date, $validity)
{
$date = Carbon::parse($date);

$this->assertEquals($validity, $date->isMemorialDay());
$this->assertSame($validity, $date->isMemorialDay());
}

public function provideMemorialDayData()
Expand All @@ -84,7 +84,7 @@ public function test_it_knows_labor_day($date, $validity)
{
$date = Carbon::parse($date);

$this->assertEquals($validity, $date->isLaborDay());
$this->assertSame($validity, $date->isLaborDay());
}

public function provideLaborDayData()
Expand All @@ -109,7 +109,7 @@ public function test_it_knows_veterans_day($date, $validity)
{
$date = Carbon::parse($date);

$this->assertEquals($validity, $date->isVeteransDay());
$this->assertSame($validity, $date->isVeteransDay());
}

public function provideVeteransDayData()
Expand All @@ -131,7 +131,7 @@ public function test_it_knows_us_thanksgiving_day($date, $validity)
{
$date = Carbon::parse($date);

$this->assertEquals($validity, $date->isAmericanThanksgiving());
$this->assertSame($validity, $date->isAmericanThanksgiving());
}

public function provideAmericanThanksgivingData()
Expand Down

0 comments on commit 5506203

Please sign in to comment.