wayfire: init #765
wayfire: init #765
Conversation
|
Hm, the home-manager module is pretty new. Should I just update the input within this PR? |
There was a problem hiding this comment.
Sadly, we cannot use
stylix.image. Wayfire currently isnt smart enough to understand what file type an image has if it doesnt have a file ending and we cannot depend on that being set.
Maybe we can pass a renamed file with something like "${stylix.image}.png"?
Hm, the home-manager module is pretty new. Should I just update the input within this PR?
Yes.
The file might be a jpeg though. I think the only automatic option is IFD, but I'm not sure what the policy is here. |
|
It seems only PNG and JPEG are supported, the implementation is a bit... primitive. |
|
Regarding the image, the way I've handled this in the past was to convert the wallpaper using ImageMagick. That means we know it's in a supported format, and also the derivation which does the conversion can output an appropriately named file. |
|
i totally forgot that you can convert images lol this should work now. i kind of forgot that |
There was a problem hiding this comment.
i totally forgot that you can convert images lol this should work now. i kind of forgot that wf-shell exists, so i think we should configure this as well. maybe dont merge this yet
We could also support Wayfire and wf-shell in separate PRs. I leave the decision up to you.
|
oh, i've already implemented the wf-shell part. i was just scared you'd merge this while i was off to get lunch ;) this is ready to merge from my point of view |
0x5a4
force-pushed
the
init-wayfire
branch
2 times, most recently
from
2eeda3b to
1ab9026
Compare
|
it seems githubs web interface has screwed me once more |
There was a problem hiding this comment.
The following question has not been addressed yet:
Wayfire currently isnt smart enough to understand what file type an image has if it doesnt have a file ending and we cannot depend on that being set.
This adds the
.pngextension to therealpathof the/nix/store/<HASH>-wayfire-background.pngsymlink. Does theconvert "$stylix_image" resultcommand actually do something? Also, does this work whenstylix.imageis not a PNG?
|
i dont understand what you mean by this. could you please elaborate what problem you're seeing here? edit: didnt intend to sound that angry, sorry |
| wayfireBackground = pkgs.runCommand "wayfire-background.png" { } '' | ||
| ${lib.getExe' pkgs.imagemagick "convert"} ${config.stylix.image} $out | ||
| ''; |
There was a problem hiding this comment.
i dont understand what you mean by this. could you please elaborate what problem you're seeing here?
Essentially, does this work even when stylix.image is not a PNG file? Note that the file extension does not dictate the actual file type:
$ file image.png
image.png: PNG image data, [...]
$ file image.jpg
image.jpg: JPEG image data, [...]Just try your module with some files and tell me if it worked.
edit: didnt intend to sound that angry, sorry
No worries. My explanation was not very clear :)
Wayfire is a 3D Wayland compositor, inspired by Compiz and based on wlroots.
Sadly, we cannot use
stylix.image. Wayfire currently isnt smart enough to understand what file type an image has if it doesnt have a file ending and we cannot depend on that being set.