Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying the type of all columns #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

garriguv
Copy link

It would be useful to use the @Type JsDoc annotation on more column types than just json and jsonb. For instance when using template literal type for entity identifiers.

This PR removes the 'Json' boolean check, opening the door to specifying the type of any column.

@aviv-skillset
Copy link

this relates to #21
@garriguv I think you may have missed that this PR was blocked for a technical reason of signed commits.
also, I wonder if typing numrange should be built in to the tool or patched by the users
image
both ways, I already made a type so if anyone willing to use it you are welcome

type LowerBoundry = "[" | "(";
type UpperBoundry = ")" | "]";
type NumRangeString = `${LowerBoundry}${number},${number}${UpperBoundry}`;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants