Added FlashMap & FlashList, support collections in ObjectInspector #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pablete1234
reviewed
Nov 2, 2023
| ((ObjectTreeNode) model.getRoot()).update(InspectorTree.this); | ||
| invalidate(); | ||
| } catch (Throwable t) { | ||
| t.printStackTrace(); |
There was a problem hiding this comment.
why is this throwing exceptions in the first place?
There was a problem hiding this comment.
due to memory misreads caused by invalid memory reads via different threads
anyway shouldn't happen anymore i hope
There was a problem hiding this comment.
if it doesn't happen, can we get rid of it?
generate class via context menu(supports only default types) added option to replace name type for every object, etc
Pablete1234
reviewed
Nov 4, 2023
| ObjectInspector.Slot slot = node.getSlot(); | ||
| if (slot.slotType == ObjectInspector.Slot.Type.OBJECT || slot.slotType == ObjectInspector.Slot.Type.PLAIN_OBJECT) { | ||
|
|
||
| StringBuilder clazzBuilder = new StringBuilder("import com.github.manolo8.darkbot.core.itf.Updatable;"); |
There was a problem hiding this comment.
this thing def needs to go in a diff class, and consider making it a template, as in, a resource text-file with some stuff like {className}, {methods} or w/e that you can search-and-replace instead of having the whole thing written with appends
Pablete1234
approved these changes
Nov 4, 2023
m9w
pushed a commit
to m9w/RealFreeDarkBot
that referenced
this pull request
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.