-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: optimized viewer msg sending with parallelism
- Loading branch information
Showing
12 changed files
with
279 additions
and
72 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| package utils | ||
|
|
||
| import "os" | ||
|
|
||
| func FixtureDevEnv() bool { | ||
| return os.Getenv("DEV_ENV") == "true" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| package utils | ||
|
|
||
| import ( | ||
| "darkbot/app/settings/logus" | ||
| "fmt" | ||
| "time" | ||
| ) | ||
|
|
||
| type timeMeasurer struct { | ||
| msg string | ||
| ops []logus.SlogParam | ||
| time_started time.Time | ||
| } | ||
|
|
||
| func NewTimeMeasure(msg string, ops ...logus.SlogParam) *timeMeasurer { | ||
| return &timeMeasurer{ | ||
| msg: msg, | ||
| ops: ops, | ||
| time_started: time.Now(), | ||
| } | ||
| } | ||
|
|
||
| func (t *timeMeasurer) Close() { | ||
| logus.Debug(fmt.Sprintf("time_measure %v | %s", time.Since(t.time_started), t.msg), t.ops...) | ||
| } | ||
|
|
||
| func TimeMeasure(callback func(), msg string, ops ...logus.SlogParam) { | ||
| time_started := NewTimeMeasure(msg, ops...) | ||
| defer time_started.Close() | ||
| callback() | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| package viewer | ||
|
|
||
| import ( | ||
| "darkbot/app/settings/logus" | ||
| "darkbot/app/settings/types" | ||
| "darkbot/app/settings/utils" | ||
| "darkbot/app/settings/worker" | ||
| "darkbot/app/settings/worker/worker_types" | ||
| "darkbot/app/viewer/apis" | ||
| "fmt" | ||
| "sync" | ||
| "time" | ||
| ) | ||
|
|
||
| type TaskRefreshChannel struct { | ||
| *worker.Task | ||
|
|
||
| // any desired arbitary data | ||
| api *apis.API | ||
| channelID types.DiscordChannelID | ||
| delayBetweenChannels types.ViewerDelayBetweenChannels | ||
| } | ||
|
|
||
| func NewRefreshChannelTask( | ||
| api *apis.API, | ||
| channelID types.DiscordChannelID, | ||
| delayBetweenChannels types.ViewerDelayBetweenChannels, | ||
| ) *TaskRefreshChannel { | ||
| task_id_gen += 1 | ||
| return &TaskRefreshChannel{ | ||
| Task: worker.NewTask(worker_types.TaskID(task_id_gen)), | ||
| api: api, | ||
| channelID: channelID, | ||
| delayBetweenChannels: delayBetweenChannels, | ||
| } | ||
| } | ||
|
|
||
| var task_id_gen int = 0 | ||
|
|
||
| var guildAntiRateLimitMutexes map[string]*sync.Mutex | ||
|
|
||
| func init() { | ||
| guildAntiRateLimitMutexes = make(map[string]*sync.Mutex) | ||
| } | ||
|
|
||
| func GetMutex(MutexKey string) *sync.Mutex { | ||
| value, ok := guildAntiRateLimitMutexes[MutexKey] | ||
|
|
||
| if ok { | ||
| return value | ||
| } | ||
|
|
||
| new_mutex := &sync.Mutex{} | ||
| guildAntiRateLimitMutexes[MutexKey] = new_mutex | ||
| return new_mutex | ||
| } | ||
|
|
||
| func (v *TaskRefreshChannel) RunTask(worker_id worker_types.WorkerID) worker_types.TaskStatusCode { | ||
| channel_info, err := v.api.Discorder.GetDiscordSession().Channel(string(v.channelID)) | ||
| if logus.CheckError(err, "unable to get channel info") { | ||
| return worker.CodeFailure | ||
| } | ||
|
|
||
| MutexKey := channel_info.GuildID | ||
| GuildMutex := GetMutex(MutexKey) | ||
| GuildMutex.Lock() | ||
| defer GuildMutex.Unlock() | ||
|
|
||
| time_run_task_started := time.Now() | ||
| time_new_channel := utils.NewTimeMeasure("new_channel", logus.ChannelID(v.channelID)) | ||
| channel := NewChannelView(v.api, v.channelID) | ||
|
|
||
| time_new_channel.Close() | ||
|
|
||
| time_render := utils.NewTimeMeasure("channel.Render", logus.ChannelID(v.channelID)) | ||
| channel.Render() | ||
| time_render.Close() | ||
|
|
||
| time_discover := utils.NewTimeMeasure("channel.Discover", logus.ChannelID(v.channelID)) | ||
| err = channel.Discover() | ||
| time_discover.Close() | ||
|
|
||
| if logus.CheckWarn(err, "unable to grab Discord msgs", logus.ChannelID(v.channelID)) { | ||
| return worker.CodeFailure | ||
| } | ||
|
|
||
| time_send := utils.NewTimeMeasure("channel.Send", logus.ChannelID(v.channelID)) | ||
| channel.Send() | ||
| time_send.Close() | ||
|
|
||
| time_delete_old := utils.NewTimeMeasure("channel.DeleteOld", logus.ChannelID(v.channelID)) | ||
| channel.DeleteOld() | ||
| time_delete_old.Close() | ||
| v.SetAsDone() | ||
| logus.Info(fmt.Sprintf("RunTask finished, TaskID=%d, elapsed=%s, started_at=%s, finished_at=%s", | ||
| v.Task.GetID(), | ||
| time.Since(time_run_task_started).String(), | ||
| time_run_task_started.String(), | ||
| time.Now().String(), | ||
| )) | ||
|
|
||
| // Important for Mutex above! Prevents Guild level rate limits. looks like 5 msg edits per 5 second at one server is good | ||
| time.Sleep(time.Duration(v.delayBetweenChannels) * time.Second) | ||
| return worker.CodeSuccess | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package viewer | ||
|
|
||
| import ( | ||
| "darkbot/app/settings/utils" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestDebugPerformance(t *testing.T) { | ||
| if !utils.FixtureDevEnv() { | ||
| return | ||
| } | ||
|
|
||
| } |
Oops, something went wrong.