Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional task to Install config.yml for specified users #18

Merged

Conversation

jasonlearst
Copy link
Contributor

Hello @darkwizard242,

I wanted the ability to specify a custom config.yml for the users of my system. I added an additional task install_config.yml which by default does not run. In order for the task to run 2 new variables need to be defined. I added them to the defaults/main.yml as undefined.

# By default, no config file will be copied (undefined)
# Example: lazydocker_config_src: /path/to/your/config.yml
lazydocker_config_src:
# By default, no users will receive the config (undefined)
# Example:
# lazydocker_users:
#   - user1
#   - user2
lazydocker_users: []

I decided I would create a PR to check if you would be interested to add this feature to the main project. Please let me know if you would like me to make any changes or clarify the changes I have already made.

@darkwizard242
Copy link
Owner

Hi @jasonlearst - Changes look good to me after review and Github Action workflows passed.

Appreciate your contribution!

If you don't wish to introduce anything else in this PR, I am good with merging it in and releasing a new version of the role.

@jasonlearst
Copy link
Contributor Author

Hi @darkwizard242 , thanks for the review and consideration! I have no other changes planned, please feel free to merge this and release whenever you would like.

@darkwizard242
Copy link
Owner

Great, will merge now and release 2.7.0

Thanks for your contribution, @jasonlearst !

@darkwizard242 darkwizard242 merged commit 00340ba into darkwizard242:master Jan 28, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants