Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vim keymap and emulation #3044

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

maranix
Copy link
Contributor

@maranix maranix commented Aug 18, 2024

Addresses #2902 by adding back support for vim-mode, which was removed from the new version.

Screenshot 2024-08-18 at 7 09 51 PM

Screenshot 2024-08-18 at 7 10 07 PM


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link
Contributor

@johnpryan johnpryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, but I'm wondering if it's possible to make the esc key return the editor back to "normal" mode.

@johnpryan johnpryan merged commit e50eaf1 into dart-lang:main Jan 15, 2025
1 check passed
@maranix
Copy link
Contributor Author

maranix commented Jan 16, 2025

@johnpryan I will look into it and open a PR if that can be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants