Elements. Migrate to Element2 #3968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dart-lang/analyzer-team |
srawlins
approved these changes
Jan 22, 2025
pq
approved these changes
Jan 22, 2025
scheglov
reviewed
Jan 22, 2025
lib/src/model/library.dart
Outdated
| @@ -315,7 +316,7 @@ class Library extends ModelElement | |||
|
|
|||
| /// The real packageMeta, as opposed to the package we are documenting with. | |||
| late final PackageMeta? packageMeta = | |||
| packageGraph.packageMetaProvider.fromElement(element2, config.sdkDir); | |||
| packageGraph.packageMetaProvider.fromElement(element as LibraryElementImpl, config.sdkDir); | |||
There was a problem hiding this comment.
Do we need specifically LibraryElementImpl here, or LibraryElement2?
Can we use .asElement2 instead?
scheglov
reviewed
Jan 22, 2025
lib/src/warnings.dart
Outdated
| UnmodifiableMapView<Element2?, Map<PackageWarning, Set<String>>> | ||
| get countedWarnings2 => UnmodifiableMapView(_countedWarnings.map((key, | ||
| value) => | ||
| MapEntry(key != null ? (key.asElement2 as Element2) : null, value))); |
There was a problem hiding this comment.
This is a strange cast key.asElement2 as Element2.
We expect to get Element2 from asElement2, right?
There was a problem hiding this comment.
Missed that, fixed. Would attribute this to the auto complete AI plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Element Model migration: