Use correct language version for formatter #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mockito used to always pass the latest language version supported by
dart_style. For projects not on that language version, this can cause a divergence between the formatting style expected in those projects and the one chosen by mockito. That is generally quite annoying, because users expect generated code to comply with their formatting standards (and having to rundart formatafterbuild_runner buildimmediately invalidates the build).This fixes the issue by passing the actual language version of the package we're generating code for instead.
This is currently breaking my pipelines in projects using mockito, it would be amazing if this could be released soon. Please let me know if there's anything more I can do to help.