Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit the range in symmetric_matrices #325

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

ev-br
Copy link
Contributor

@ev-br ev-br commented Dec 1, 2024

#280 started showing up in recent, unrelated PRs: #280, #324

Try limiting the range for drawing matrix elements, to simplify an assume just below: to avoid HealthCheck warning of gh-280, avoid assume, only generate matrix elements from the range of (1,10)`. This is unlikely to be too important given that we're not running value tests either way.

@ev-br ev-br requested a review from asmeurer December 1, 2024 08:49
@ev-br ev-br force-pushed the eigvals_health_check branch 2 times, most recently from 110a04f to d64e969 Compare December 1, 2024 13:09
otherwise, using assume(...) triggers a HealthCheck warning that the strategy
filters too much
@ev-br
Copy link
Contributor Author

ev-br commented Dec 4, 2024

Merged this with a TODO comment to unblock other PRs across the repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant