Add an ability to get ManagedServer from Manager #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this PR with carefully-written commit messages. Unfortunately, I'm not sure if this PR should be merged in its current state. I feel like there should be better ways than simply drilling holes into existing encapsulations. Nonetheless, I understand your use case, and will keep it in mind when I make changes in the future. I'd also appreciate it if you could open an issue to discuss with me first before opening PRs like this. |
|
Well, let's then switch to issues and see how far we can go :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be useful when using
shadowsocks-goas a library, and having HTTP API enabled is not possible.