Add support for Lakehouse monitoring in bundles #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aravind-segu
commented
Mar 24, 2024
aravind-segu
commented
Mar 24, 2024
pietern
changed the title
pietern
reviewed
Mar 25, 2024
bundle/deploy/terraform/tfdyn/convert_lakehouse_monitor_test.go
Outdated
Show resolved
Hide resolved
pietern
reviewed
Mar 25, 2024
aravind-segu
force-pushed
the
lakehouseMonitoring
branch
from
8bbbcdb to
ea7b74b
Compare
|
Regarding the hacky approach |
|
Tests are failing because of the change to not avoid json |
andrewnester
requested changes
Apr 23, 2024
aravind-segu
force-pushed
the
lakehouseMonitoring
branch
from
a915754 to
cfe77aa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1307 +/- ##
==========================================
+ Coverage 52.25% 53.58% +1.33%
==========================================
Files 317 351 +34
Lines 18004 20268 +2264
==========================================
+ Hits 9408 10861 +1453
- Misses 7903 8609 +706
- Partials 693 798 +105 ☔ View full report in Codecov by Sentry. |
pietern
reviewed
May 15, 2024
aravind-segu
force-pushed
the
lakehouseMonitoring
branch
from
8d4a1a9 to
c240c31
Compare
pietern
reviewed
May 31, 2024
|
The TF bump is happening in #1460. |
pietern
changed the title
pietern
approved these changes
May 31, 2024
andrewnester
approved these changes
May 31, 2024
pietern
added a commit
that referenced
this pull request
Jun 4, 2024
CLI: * Update OpenAPI spec ([#1466](#1466)). Bundles: * Upgrade TF provider to 1.46.0 ([#1460](#1460)). * Add support for Lakehouse monitoring ([#1307](#1307)). * Make dbt-sql and default-sql templates public ([#1463](#1463)). Internal: * Abstract over filesystem interaction with libs/vfs ([#1452](#1452)). * Add `filer.Filer` to read notebooks from WSFS without omitting their extension ([#1457](#1457)). * Fix listing notebooks in a subdirectory ([#1468](#1468)). API Changes: * Changed `databricks account storage-credentials list` command to return . * Added `databricks consumer-listings batch-get` command. * Added `databricks consumer-providers batch-get` command. * Removed `databricks apps create-deployment` command. * Added `databricks apps deploy` command. OpenAPI commit 37b925eba37dfb3d7e05b6ba2d458454ce62d3a0 (2024-06-03) Dependency updates: * Bump github.com/hashicorp/go-version from 1.6.0 to 1.7.0 ([#1454](#1454)). * Bump github.com/hashicorp/hc-install from 0.6.4 to 0.7.0 ([#1453](#1453)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
CLI: * Update OpenAPI spec ([#1466](#1466)). Bundles: * Upgrade TF provider to 1.46.0 ([#1460](#1460)). * Add support for Lakehouse monitoring ([#1307](#1307)). * Make dbt-sql and default-sql templates public ([#1463](#1463)). Internal: * Abstract over filesystem interaction with libs/vfs ([#1452](#1452)). * Add `filer.Filer` to read notebooks from WSFS without omitting their extension ([#1457](#1457)). * Fix listing notebooks in a subdirectory ([#1468](#1468)). API Changes: * Changed `databricks account storage-credentials list` command to return . * Added `databricks consumer-listings batch-get` command. * Added `databricks consumer-providers batch-get` command. * Removed `databricks apps create-deployment` command. * Added `databricks apps deploy` command. OpenAPI commit 37b925eba37dfb3d7e05b6ba2d458454ce62d3a0 (2024-06-03) Dependency updates: * Bump github.com/hashicorp/go-version from 1.6.0 to 1.7.0 ([#1454](#1454)). * Bump github.com/hashicorp/hc-install from 0.6.4 to 0.7.0 ([#1453](#1453)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Changes This field was special-cased in #1307 because it's not part of the JSON payload in the SDK struct. This approach, while pragmatic, meant it didn't show up in the JSON schema. While debugging an issue with quality monitors in #1900, I couldn't figure out why I was getting schema errors on this field, or how it was passed through to the TF representation. This commit removes the special case and makes it behave like everything else. ## Tests * Unit tests pass. * Confirmed that the updated schema failed validation before this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change adds support for Lakehouse monitoring in bundles.
The associated resource type name is "quality monitor".
Testing
Unit tests.