Migrate path translation tests to acceptance tests #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Jan 13, 2025
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
approved these changes
Jan 14, 2025
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
force-pushed
the
path-translation-acceptance-1
branch
from
01b581c to
e683c1b
Compare
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
Blocked on #2145. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
## Changes This came up in #2122 where relative library paths showed up with backslashes on Windows. It's hard to run acceptance tests where paths may be in either form. This change updates path translation logic to always use forward slash-separated paths, including for absolute paths. ## Tests * Unit tests pass. * Confirmed that code where library paths are used uses the `filepath` package for path manipulation. The functions in this package always normalize their inputs to be platform-native paths. * Confirmed that code that uses absolute paths works with forward slash-separated paths on Windows.
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The assertions on the output made are now captured in the
output.*files. These don't capture intent like actual assertions do, but we still have regular test coverage in the path translation tests underbundle/config/mutator.Tests
Tests pass.