Added separate methods for required path and body parameters and added Must/CanUseJson methods #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d Must/CanUseJson methods
mgyucht
approved these changes
Oct 23, 2023
| // JSON input to set all required fields for request. | ||
| // If we can do so, it means we can ignore all positional arguments | ||
| // passed for a certaing command and only use JSON input passed via --json flag. | ||
| func (m *Method) CanSetRequiredFieldsFromJson() bool { |
There was a problem hiding this comment.
Should we leave this here so that we don't break compilation of the new tool with older versions of the SDK (e.g. someone checked out an older version of the SDK and is doing local testing)? We can deprecate this with a message saying not to use this method. WDYT?
There was a problem hiding this comment.
@mgyucht this is only for code generation and an SDK exposed method and it is not anymore anywhere (removed usage of it in CLI with this PR databricks/cli#905) so it should be safe to be removed
pietern
reviewed
Oct 24, 2023
Co-authored-by: Pieter Noordhuis <pieter.noordhuis@databricks.com>
Codecov ReportAttention:
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
…cks/databricks-sdk-go into improve-required-path-parameters
pietern
approved these changes
Oct 24, 2023
github-merge-queue bot
pushed a commit
to databricks/cli
that referenced
this pull request
Oct 24, 2023
…arameters and JSON input (#905) ## Changes Simplified code generation logic for handling path and request body parameters and JSON input Note: relies on these PRs: databricks/databricks-sdk-go#666 databricks/databricks-sdk-go#669 databricks/databricks-sdk-go#670
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In attempt to simplify code generation logic (databricks/cli#905) added separate methods for required path and body parameters and added Must/CanUseJson methods.
Tests
make testpassingmake fmtapplied[ ] relevant integration tests applied