Implemented MultiIndex.equal_levels #1789
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itholic
commented
Sep 23, 2020
HyukjinKwon
reviewed
Sep 24, 2020
ueshin
reviewed
Sep 25, 2020
ueshin
reviewed
Sep 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #1789 +/- ##
==========================================
- Coverage 94.64% 94.61% -0.04%
==========================================
Files 49 49
Lines 10818 10724 -94
==========================================
- Hits 10239 10146 -93
+ Misses 579 578 -1
Continue to review full report at Codecov.
|
|
Could someone double check this just once more? Seems fine to me. |
|
I'll take a look later. |
|
Sure, thanks :) |
ueshin
reviewed
Dec 3, 2020
There was a problem hiding this comment.
I can see some issues:
>>> pmidx1 = pd.MultiIndex.from_tuples([("a", "x"), ("b", "y"), ("c", "z")])
>>> pmidx2 = pd.MultiIndex.from_tuples([("a", "y"), ("b", "x"), ("c", "z")])
>>> pmidx1.equal_levels(pmidx2)
True
>>> kmidx1 = ks.from_pandas(pmidx1)
>>> kmidx2 = ks.from_pandas(pmidx2)
>>> kmidx1.equal_levels(kmidx2)
Falseor
>>> pmidx1 = pd.MultiIndex.from_tuples([("a", "x"), ("b", "y"), ("c", "z"), ("a", "y")])
>>> pmidx2 = pd.MultiIndex.from_tuples([("a", "y"), ("b", "x"), ("c", "z"), ("c", "x")])
>>> pmidx1.equal_levels(pmidx2)
True
>>> kmidx1 = ks.from_pandas(pmidx1)
>>> kmidx2 = ks.from_pandas(pmidx2)
>>> kmidx1.equal_levels(kmidx2)
False| return False | ||
| self_frame = self.sort_values().to_frame() | ||
| other_frame = other.sort_values().to_frame() | ||
| with option_context("compute.ops_on_diff_frames", True): |
There was a problem hiding this comment.
We might avoid force enabling compute.ops_on_diff_frames. let's see.
There was a problem hiding this comment.
Okay, thanks for the review! Let me resolve the comments
HyukjinKwon
pushed a commit
to apache/spark
that referenced
this pull request
Oct 1, 2021
### What changes were proposed in this pull request?
This PR proposes implementing `MultiIndex.equal_levels`.
```python
>>> psmidx1 = ps.MultiIndex.from_tuples([("a", "x"), ("b", "y"), ("c", "z")])
>>> psmidx2 = ps.MultiIndex.from_tuples([("b", "y"), ("a", "x"), ("c", "z")])
>>> psmidx1.equal_levels(psmidx2)
True
>>> psmidx1 = ps.MultiIndex.from_tuples([("a", "x"), ("b", "y"), ("c", "z"), ("a", "y")])
>>> psmidx2 = ps.MultiIndex.from_tuples([("a", "y"), ("b", "x"), ("c", "z"), ("c", "x")])
>>> psmidx1.equal_levels(psmidx2)
True
```
This was originally proposed in databricks/koalas#1789, and all reviews in origin PR has been resolved.
### Why are the changes needed?
We should support the pandas API as much as possible for pandas-on-Spark module.
### Does this PR introduce _any_ user-facing change?
Yes, the `MultiIndex.equal_levels` API is available.
### How was this patch tested?
Unittests
Closes #34113 from itholic/SPARK-36435.
Lead-authored-by: itholic <haejoon.lee@databricks.com>
Co-authored-by: Haejoon Lee <44108233+itholic@users.noreply.github.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes
MultiIndex.equal_levels.