Skip to content

Commit

Permalink
[Internal] Generate effective fields based of isServiceProposedIfEmpty (
Browse files Browse the repository at this point in the history
#4282)

## Changes
<!-- Summary of your changes that are easy to understand -->
This PR introduces a change that uses the new isServiceProposedIfEmpty
annotation to generate the TFSDK structs. With this update, only the
fields with this annotation will have an EffectiveField combo.
Previously, fields that were marked as Computed would automatically get
this combo, but that's no longer the case. As a result, most of the
EffectiveField combos are now removed.

## Tests
<!-- 
How is this tested? Please see the checklist below and also describe any
other relevant tests
-->

- [ ] `make test` run locally
- [ ] relevant change in `docs/` folder
- [ ] covered with integration tests in `internal/acceptance`
- [ ] relevant acceptance tests are passing
- [ ] using Go SDK

Co-authored-by: Omer Lachish <rauchy@users.noreply.github.com>
  • Loading branch information
rauchy and rauchy authored Nov 29, 2024
1 parent cb8fd95 commit 448f866
Show file tree
Hide file tree
Showing 6 changed files with 94 additions and 690 deletions.
126 changes: 14 additions & 112 deletions internal/service/apps_tf/model.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 8 additions & 20 deletions internal/service/catalog_tf/model.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 448f866

Please sign in to comment.