fix mws workspaces mishandling empty response

databricks · Jan 17, 2025 · 9e9c8d9 · 9e9c8d9
1 parent 6b9a584
commit 9e9c8d9
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/mws/data_mws_workspaces.go b/mws/data_mws_workspaces.go
@@ -9,7 +9,7 @@ import (
 
 func DataSourceMwsWorkspaces() common.Resource {
 	type mwsWorkspacesData struct {
-		Ids map[string]int64 `json:"ids,omitempty" tf:"computed"`
+		Ids map[string]int64 `json:"ids" tf:"computed"`
 	}
 	return common.DataResource(mwsWorkspacesData{}, func(ctx context.Context, e any, c *common.DatabricksClient) error {
 		data := e.(*mwsWorkspacesData)

diff --git a/mws/data_mws_workspaces_test.go b/mws/data_mws_workspaces_test.go
@@ -48,3 +48,23 @@ func TestCatalogsData_Error(t *testing.T) {
 		ID:          "_",
 	}.ExpectError(t, "i'm a teapot")
 }
+
+func TestDataSourceMwsWorkspaces_Empty(t *testing.T) {
+	qa.ResourceFixture{
+		Fixtures: []qa.HTTPFixture{
+			{
+				Method:   "GET",
+				Resource: "/api/2.0/accounts/abc/workspaces",
+
+				Response: []Workspace{},
+			},
+		},
+		AccountID:   "abc",
+		Resource:    DataSourceMwsWorkspaces(),
+		Read:        true,
+		NonWritable: true,
+		ID:          "_",
+	}.ApplyAndExpectData(t, map[string]any{
+		"ids": map[string]any{},
+	})
+}