Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deployment field to resource_job #2821

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Add deployment field to resource_job #2821

merged 1 commit into from
Oct 20, 2023

Conversation

shreyas-goenka
Copy link
Contributor

@shreyas-goenka shreyas-goenka commented Oct 19, 2023 •
edited
Loading

Changes

This PR adds the deployment field to the Job resource. This allows jobs created to be aware that they are a part of a bundle, as well as communicate bundle metadata with the job.

Tests

Unit test

@shreyas-goenka shreyas-goenka requested review from a team as code owners October 19, 2023 15:15
@shreyas-goenka shreyas-goenka requested review from tanmay-db, pietern, alexott and mgyucht and removed request for a team October 19, 2023 15:15
alexott
alexott reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-wise is ok, but should we document it?

@shreyas-goenka
Copy link
Contributor Author

I'd recommend against documenting it because:

  1. It's in private preview
  2. The only usecase today and forseeable future is for Jobs to know they are part of a bundle. We don't want users to set it manually.

@shreyas-goenka shreyas-goenka added this pull request to the merge queue Oct 20, 2023
Merged via the queue into master with commit 2183253 Oct 20, 2023
7 checks passed
@shreyas-goenka shreyas-goenka deleted the job-deployment-path branch October 20, 2023 13:23
@mgyucht mgyucht mentioned this pull request Oct 25, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexott alexott alexott approved these changes

@tanmay-db tanmay-db Awaiting requested review from tanmay-db tanmay-db was automatically assigned from databricks/eng-plat-auto-exp-reviewers

@pietern pietern Awaiting requested review from pietern

@mgyucht mgyucht Awaiting requested review from mgyucht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreyas-goenka @alexott