Exporter: fix generation of names for databricks_library resources
#2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexott
force-pushed
the
exporter-library-names-fix
branch
from
6c2449e to
6d77c9f
Compare
Internally, exporter uses following resource ID for `databricks_library`: `<cluster_id>/<type>:coordinate` (i.e., `0426-122546-8xi8q5o3/pypi:chispa`). When generating final name of the resource, this name is normalized, and checked if it's starting with a number, as Terraform doesn't allow identifiers to start with a number. If the final name starts with number, then the artificial final name is generated consisting in form of `r<first 12 digits of MD5 of the original name>`. This leads to generation of duplicate resources in case if cluster ID started with a number, and the same library was attached to the cluster multiple times, having only difference in the character case, like, `Chispa` and `chispa` (our clusters UI allows that). This PR fixes this issue with following changes: * add `lib_` prefix to the library name together with first 8 numbers of the MD5 of library ID * when generating resource name in form of `r<first 12 digits of MD5 of the original name>`, calculate MD5 of the original string, not the lower-cased form
alexott
force-pushed
the
exporter-library-names-fix
branch
from
6d77c9f to
aefa94e
Compare
Codecov Report
@@ Coverage Diff @@
## master #2832 +/- ##
=========================================
Coverage ? 84.65%
=========================================
Files ? 152
Lines ? 13241
Branches ? 0
=========================================
Hits ? 11209
Misses ? 1418
Partials ? 614
|
mgyucht
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Internally, the exporter uses the following resource ID for
databricks_library:<cluster_id>/<type>:coordinate(i.e.,0426-122546-8xi8q5o3/pypi:chispa).When generating the final name of the resource, this name is normalized and checked if it's starting with a number, as Terraform doesn't allow identifiers to start with a number. If the final name starts with a number, then the artificial final name is generated consisting in the form of
r<first 12 digits of MD5 of the original name>. This leads to the generation of duplicate resources in case if cluster ID starts with a number, and the same library was attached to the cluster multiple times, having only differences in the character case, like,Chispaandchispa(our clusters UI allows that).This PR fixes this issue with the following changes:
lib_prefix to the library name together with the first 8 numbers of the MD5 of the library IDr<first 12 digits of MD5 of the original name>, calculate MD5 of the original string, not the lower-cased formPlease note that you will need to perform a full export because resource names has changed
Tests
make testrun locallydocs/folderinternal/acceptance