Exporter: adjust generation & normalization of databricks_job names
#2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `context.go` we had very aggressive name normalization rule `@.*$` that not necessary stripped parts of the job name. Also added handling of the empty job name.
Codecov Report
@@ Coverage Diff @@
## master #2836 +/- ##
=========================================
Coverage ? 84.67%
=========================================
Files ? 152
Lines ? 13243
Branches ? 0
=========================================
Hits ? 11214
Misses ? 1415
Partials ? 614
|
mgyucht
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In
context.gowe had a very aggressive name normalization rule@.*$that did not necessarily strip parts of the job name. Also added handling of the empty job name.Tests
make testrun locallydocs/folderinternal/acceptance