-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Vector Search Indexes #3266
Conversation
9fac174
to
c86716d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3266 +/- ##
==========================================
- Coverage 83.56% 83.51% -0.06%
==========================================
Files 177 178 +1
Lines 16523 16598 +75
==========================================
+ Hits 13808 13862 +54
- Misses 1877 1891 +14
- Partials 838 845 +7
|
d140380
to
9f5dc0e
Compare
This is initial work - right now things are blocked by errors in OpenAPI spec, and as result, Go SDK has incorrect structs. So we need to wait until spec is fixed
9f5dc0e
to
a8600c1
Compare
Regarding integration tests - it's not clear how to programmatically pull models from the Marketplace :-( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with two small nits, discussed adding integration test in a follow-up offline.
Changes
This is initial work - right now things are blocked by errors in OpenAPI spec, and as result, Go SDK has incorrect structs. So we need to wait until spec is fixed
Tests
make test
run locallydocs/
folderinternal/acceptance