Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Vector Search Indexes #3266

Merged
merged 9 commits into from
Mar 23, 2024
Merged

Add support for Vector Search Indexes #3266

merged 9 commits into from
Mar 23, 2024

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Feb 15, 2024

Changes

This is initial work - right now things are blocked by errors in OpenAPI spec, and as result, Go SDK has incorrect structs. So we need to wait until spec is fixed

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@alexott alexott force-pushed the vector-search-indexes branch from 9fac174 to c86716d Compare February 29, 2024 13:26
@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 73.43750% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 83.51%. Comparing base (fdd0fe9) to head (bb7dc9f).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3266      +/-   ##
==========================================
- Coverage   83.56%   83.51%   -0.06%     
==========================================
  Files         177      178       +1     
  Lines       16523    16598      +75     
==========================================
+ Hits        13808    13862      +54     
- Misses       1877     1891      +14     
- Partials      838      845       +7     
Files Coverage Δ
provider/provider.go 94.70% <100.00%> (+0.02%) ⬆️
vectorsearch/resource_vector_search_endpoint.go 80.76% <ø> (ø)
vectorsearch/resource_vector_search_index.go 73.01% <73.01%> (ø)

... and 2 files with indirect coverage changes

@alexott alexott force-pushed the vector-search-indexes branch 2 times, most recently from d140380 to 9f5dc0e Compare March 12, 2024 18:05
alexott added 4 commits March 19, 2024 15:32
This is initial work - right now things are blocked by errors in OpenAPI spec, and as
result, Go SDK has incorrect structs. So we need to wait until spec is fixed
@alexott alexott force-pushed the vector-search-indexes branch from 9f5dc0e to a8600c1 Compare March 19, 2024 14:36
@alexott alexott marked this pull request as ready for review March 19, 2024 15:14
@alexott alexott requested review from a team as code owners March 19, 2024 15:14
@alexott alexott requested review from mgyucht and removed request for a team March 19, 2024 15:14
@alexott
Copy link
Contributor Author

alexott commented Mar 19, 2024

Regarding integration tests - it's not clear how to programmatically pull models from the Marketplace :-(

@alexott
Copy link
Contributor Author

alexott commented Mar 21, 2024

@mgyucht to add acceptance tests we need to fix a number of issues: #3388, #3383, #3375, plus solve the problem with registration of models from the marketplace...

Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two small nits, discussed adding integration test in a follow-up offline.

docs/resources/vector_search_index.md Outdated Show resolved Hide resolved
vectorsearch/resource_vector_search_index.go Show resolved Hide resolved
@alexott alexott added this pull request to the merge queue Mar 23, 2024
Merged via the queue into main with commit 3d30621 Mar 23, 2024
5 checks passed
@alexott alexott deleted the vector-search-indexes branch March 23, 2024 09:40
@hectorcast-db hectorcast-db mentioned this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants