Exporter: Don't generate resources with empty names #3345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very often we emit resources that don't exist in backend, and this creates incorrect resources without actual data. Typically this happens when objects are deleted, but still referenced from jobs, dashboards, etc. This PR skips generation of resources where the `name` is required attribute but it's empty in the state, meaning that resource doesn't exist on the backend. This is done for the following resources: * `databricks_sql_query` * `databricks_sql_endpoint` * `databricks_sql_alert * `databricks_catalog` * `databricks_schema` * `databricks_volume` * `databricks_sql_table` * `databricks_registered_model`
hectorcast-db
approved these changes
Mar 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Very often we emit resources that don't exist on the backend, and this creates incorrect resources without actual data. Typically this happens when objects are deleted but still referenced from jobs, dashboards, etc.
This PR skips the generation of resources where the
nameis the required attribute but it's empty in the state, meaning that resource doesn't exist on the backend. This is done for the following resources:databricks_sql_querydatabricks_sql_endpointdatabricks_catalogdatabricks_schemadatabricks_volumedatabricks_sql_tabledatabricks_registered_modelTests
make testrun locallydocs/folderinternal/acceptance