Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource provider registry #3347

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Conversation

edwardfeng-db
Copy link
Contributor

@edwardfeng-db edwardfeng-db commented Mar 7, 2024

Changes

  • Part of [Closed] jobs gosdk migration #3320
  • Add resource provider registry to avoid redundant alias and customization definitions
  • Update Library resource to follow the ResourceProvider interface

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 83.43%. Comparing base (ddc5c1a) to head (966f634).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3347      +/-   ##
==========================================
- Coverage   83.45%   83.43%   -0.03%     
==========================================
  Files         176      176              
  Lines       16166    16219      +53     
==========================================
+ Hits        13492    13532      +40     
- Misses       1855     1865      +10     
- Partials      819      822       +3     
Files Coverage Δ
clusters/resource_cluster.go 87.25% <100.00%> (+0.09%) ⬆️
clusters/resource_library.go 77.14% <100.00%> (-0.33%) ⬇️
common/reflect_resource.go 83.77% <0.00%> (-1.14%) ⬇️

... and 3 files with indirect coverage changes

@edwardfeng-db edwardfeng-db requested a review from mgyucht March 10, 2024 23:44
@edwardfeng-db edwardfeng-db marked this pull request as ready for review March 10, 2024 23:44
@edwardfeng-db edwardfeng-db requested review from a team as code owners March 10, 2024 23:44
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nits, otherwise LGTM. Very excited to see the Jobs migration.

common/reflect_resource.go Outdated Show resolved Hide resolved
clusters/resource_library.go Outdated Show resolved Hide resolved
@edwardfeng-db edwardfeng-db added this pull request to the merge queue Mar 11, 2024
Merged via the queue into main with commit 410ca1d Mar 11, 2024
5 checks passed
@edwardfeng-db edwardfeng-db deleted the edwardfeng-db/add-tf-registry branch March 11, 2024 13:19
@hectorcast-db hectorcast-db mentioned this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants