Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update documentation about databricks-managed service principals #3350

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Mar 8, 2024

Changes

Clarify in the docs that Databricks-managed service principals could be used on all clouds

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@alexott alexott requested review from a team as code owners March 8, 2024 08:03
@alexott alexott requested review from mgyucht and removed request for a team March 8, 2024 08:03
@alexott alexott added the docs add explicit documentation about corner case label Mar 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.43%. Comparing base (64ffcac) to head (2cfa0df).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3350   +/-   ##
=======================================
  Coverage   83.43%   83.43%           
=======================================
  Files         176      176           
  Lines       16219    16219           
=======================================
  Hits        13532    13532           
  Misses       1865     1865           
  Partials      822      822           

Clarify in the docs that Databricks-managed service principals could be used on all clouds
@alexott alexott force-pushed the docs-db-managed-sp branch from 7e717ef to 2cfa0df Compare March 11, 2024 15:19
@nkvuong nkvuong added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit 05cdc84 Mar 13, 2024
5 checks passed
@nkvuong nkvuong deleted the docs-db-managed-sp branch March 13, 2024 15:27
@hectorcast-db hectorcast-db mentioned this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs add explicit documentation about corner case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants