Fix bug in collectionToMaps #3581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3581 +/- ##
==========================================
- Coverage 82.55% 82.54% -0.02%
==========================================
Files 187 187
Lines 19156 19160 +4
==========================================
+ Hits 15815 15816 +1
- Misses 2413 2414 +1
- Partials 928 930 +2
|
5 tasks
nkvuong
approved these changes
May 15, 2024
mgyucht
reviewed
May 15, 2024
hectorcast-db
added a commit
that referenced
this pull request
May 23, 2024
### New Features and Improvements * Fix bug in collectionToMaps ([#3581](#3581)). * Added `databricks_enhanced_security_monitoring_workspace_setting ` resource for ESC (Enhanced Compliance and Security) settings ([#3563](#3563)). * Added `databricks_automatic_cluster_update_workspace_setting` resource ([#3444](#3444)). * Add databricks_compliance_security_profile_workspace_setting resource ([#3564](#3564)). * Make customizable error logs more readable ([#3583](#3583)). * Fix control run state failures for `databricks_job` resource ([#3585](#3585)). * Added support for popular column types for `resource_sql_table` ([#3528](#3528)). * Modify state upgrader to remove `ebs_volume_iops` set to zero ([#3601](#3601)). * Add route optimized option to model serving terraform ([#3572](#3572)). * Rename lakehouse monitor to quality monitor ([#3584](#3584)). ### Documentation Changes * Fix documentation for `databricks_storage_credential` and `databricks_external_location` data sources ([#3588](#3588)). ### Exporter * Add support for `databricks_mws_permission_assignment` resource ([#3562](#3562)). * Don't list directories in the incremental mode ([#3569](#3569)). ### Internal Changes * Add TestMwsAccServicePrincipalResourceOnAws to flaky tests ([#3580](#3580)). ### Dependency updates * Bump github.com/databricks/databricks-sdk-go from 0.40.1 to 0.41.0 ([#3604](#3604)). * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.33.0 to 2.34.0 ([#3594](#3594)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 23, 2024
* Release v1.45.0 ### New Features and Improvements * Fix bug in collectionToMaps ([#3581](#3581)). * Added `databricks_enhanced_security_monitoring_workspace_setting ` resource for ESC (Enhanced Compliance and Security) settings ([#3563](#3563)). * Added `databricks_automatic_cluster_update_workspace_setting` resource ([#3444](#3444)). * Add databricks_compliance_security_profile_workspace_setting resource ([#3564](#3564)). * Make customizable error logs more readable ([#3583](#3583)). * Fix control run state failures for `databricks_job` resource ([#3585](#3585)). * Added support for popular column types for `resource_sql_table` ([#3528](#3528)). * Modify state upgrader to remove `ebs_volume_iops` set to zero ([#3601](#3601)). * Add route optimized option to model serving terraform ([#3572](#3572)). * Rename lakehouse monitor to quality monitor ([#3584](#3584)). ### Documentation Changes * Fix documentation for `databricks_storage_credential` and `databricks_external_location` data sources ([#3588](#3588)). ### Exporter * Add support for `databricks_mws_permission_assignment` resource ([#3562](#3562)). * Don't list directories in the incremental mode ([#3569](#3569)). ### Internal Changes * Add TestMwsAccServicePrincipalResourceOnAws to flaky tests ([#3580](#3580)). ### Dependency updates * Bump github.com/databricks/databricks-sdk-go from 0.40.1 to 0.41.0 ([#3604](#3604)). * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.33.0 to 2.34.0 ([#3594](#3594)). * fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
collectionToMapscollectionToMap, in the callback function we pass intoiterFields, we are not handling the case where a list schema's Elemis a*schema.Schema`.StructToDataintocollectionToMapsTests
make testrun locallydocs/folderinternal/acceptance