Allow updating of comment in delta share resource #3629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: Based on the feedback in databricks#3529 (comment), that pull request needed to be extended to handle updates to `comment` in the share resource How: Bit of a refactor to create `UpdateShareMeta` which takes in the ctx, the resource information, client and the two different values in the share. If only th `owner` is changed, then a call to set the owner is set to the API. If the `owner` and `comment` are changed then both are set to the API. And likewise, handling just the `comment` change. A test was added to demostrate that
5 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## share-issue #3629 +/- ##
===============================================
- Coverage 82.75% 82.67% -0.08%
===============================================
Files 183 183
Lines 18814 18832 +18
===============================================
Hits 15569 15569
- Misses 2328 2343 +15
- Partials 917 920 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Why:
Based on the feedback in
#3529 (comment), that pull request needed to be extended to handle updates to
commentin the share resourceHow:
Bit of a refactor to create
UpdateShareMetawhich takes in the ctx, the resource information, client and the two different values in the share. If only thowneris changed, then a call to set the owner is set to the API. If theownerandcommentare changed then both are set to the API.And likewise, handling just the
commentchange.A test was added to demonstrate that
Tests
Added new test
make testrun locallydocs/folderinternal/acceptance