Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document support of requirements.txt specification in cluster libraries #3637

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Jun 3, 2024

Changes

Support for requirements parameter came via SDK, but documentation was missing.

Fixes #3471

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

…ries

Support for `requirements` parameter came via SDK, but documentation was missing.

Fixes #3471
@alexott alexott requested review from a team as code owners June 3, 2024 10:24
@alexott alexott requested review from mgyucht and removed request for a team June 3, 2024 10:24
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.66%. Comparing base (cd9df5e) to head (bb22a16).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3637   +/-   ##
=======================================
  Coverage   81.66%   81.66%           
=======================================
  Files         193      193           
  Lines       19545    19545           
=======================================
  Hits        15961    15961           
  Misses       2634     2634           
  Partials      950      950           

@nkvuong nkvuong added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 867f829 Jun 3, 2024
5 checks passed
@nkvuong nkvuong deleted the issue-3471 branch June 3, 2024 12:46
pietern added a commit that referenced this pull request Jun 5, 2024
### New Features and Improvements

* Added `gcp_workspace_sa` computed attribute to `databricks_mws_workspaces` ([#3617](#3617)).
* Added `storage_credential_id` attribute to `databricks_storage_credential` resource ([#3636](#3636)).
* Added `full_name` attribute to `databricks_system_schema` resource ([#3634](#3634)).
* Fix SQL table column type throws error ([#3501](#3501)).
* Add `aws_unity_catalog_assume_role_policy` data source ([#3622](#3622)).
* Fix bug for job creation with `num_workers = 0` ([#3642](#3642)).

### Documentation Changes

* Document support of `requirements.txt` specification in cluster libraries ([#3637](#3637)).
* Clarify about trailing slash character in file arrival trigger URL in `databricks_job` resource ([#3635](#3635)).

Dependency updates:

 * Bump golang.org/x/mod from 0.17.0 to 0.18.0 ([#3643](#3643)).
@pietern pietern mentioned this pull request Jun 5, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 5, 2024
* Release v1.47.0

### New Features and Improvements

* Added `gcp_workspace_sa` computed attribute to `databricks_mws_workspaces` ([#3617](#3617)).
* Added `storage_credential_id` attribute to `databricks_storage_credential` resource ([#3636](#3636)).
* Added `full_name` attribute to `databricks_system_schema` resource ([#3634](#3634)).
* Fix SQL table column type throws error ([#3501](#3501)).
* Add `aws_unity_catalog_assume_role_policy` data source ([#3622](#3622)).
* Fix bug for job creation with `num_workers = 0` ([#3642](#3642)).

### Documentation Changes

* Document support of `requirements.txt` specification in cluster libraries ([#3637](#3637)).
* Clarify about trailing slash character in file arrival trigger URL in `databricks_job` resource ([#3635](#3635)).

Dependency updates:

 * Bump golang.org/x/mod from 0.17.0 to 0.18.0 ([#3643](#3643)).

* Update CHANGELOG.md
pietern added a commit that referenced this pull request Jun 5, 2024
* Release v1.47.0

### New Features and Improvements

* Added `gcp_workspace_sa` computed attribute to `databricks_mws_workspaces` ([#3617](#3617)).
* Added `storage_credential_id` attribute to `databricks_storage_credential` resource ([#3636](#3636)).
* Added `full_name` attribute to `databricks_system_schema` resource ([#3634](#3634)).
* Fix SQL table column type throws error ([#3501](#3501)).
* Add `aws_unity_catalog_assume_role_policy` data source ([#3622](#3622)).
* Fix bug for job creation with `num_workers = 0` ([#3642](#3642)).

### Documentation Changes

* Document support of `requirements.txt` specification in cluster libraries ([#3637](#3637)).
* Clarify about trailing slash character in file arrival trigger URL in `databricks_job` resource ([#3635](#3635)).

Dependency updates:

 * Bump golang.org/x/mod from 0.17.0 to 0.18.0 ([#3643](#3643)).

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] databricks_library resource does not support workspace files
3 participants