Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporter: Emit directories during the listing only if they are explicitly configured in -listing #3673

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Exporter: Emit directories during the listing only if they are explicitly configured in -listing #3673

merged 1 commit into from
Jul 9, 2024

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Jun 13, 2024 •
edited
Loading

Changes

The exporter emitted directories even if they were specified only in -services, leading to the exporting of unnecessary objects. To return to the behavior between 1.38 and 1.45, add directories to the -listing

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@alexott
Exporter: Emit directories during the listing only if they are explic…
09ad85c 
…itly configured in `-listing`

Exporter emitted directories even if they were specified only in `-services`, leading to
exporting of not necessary objects...
@alexott alexott requested review from a team as code owners June 13, 2024 12:39
@alexott alexott requested review from mgyucht and removed request for a team June 13, 2024 12:39
@alexott alexott added the exporter TF configuration generator label Jun 13, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.60%. Comparing base (e166af0) to head (09ad85c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3673      +/-   ##
==========================================
- Coverage   81.61%   81.60%   -0.01%     
==========================================
  Files         196      196              
  Lines       19739    19742       +3     
==========================================
+ Hits        16109    16110       +1     
- Misses       2671     2672       +1     
- Partials      959      960       +1
Files Coverage Δ
exporter/util.go 76.19% <0.00%> (ø)

... and 1 file with indirect coverage changes

@alexott alexott added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit 9c9bf2b Jul 9, 2024
5 checks passed
@alexott alexott deleted the exporter-directories-handling-in-listing branch July 9, 2024 09:20
tanmay-db added a commit that referenced this pull request Jul 9, 2024
@tanmay-db
Release v1.48.3
f631584 
### Internal Changes

 * Add Release tag ([#3748](#3748)).
 * Improve Changelog by grouping changes ([#3747](#3747)).
 * Upgrade Go SDK to v0.43.2 ([#3750](#3750)).

### Other Changes

 * Add `databricks_schema` data source ([#3732](#3732)).
 * Add new APIErrorBody struct and update deps ([#3745](#3745)).
 * Added support for binding storage credentials and external locations to specific workspaces ([#3678](#3678)).
 * Adds `databricks_volume` as data source  ([#3211](#3211)).
 * Change TF registry ownership ([#3736](#3736)).
 * Exporter: Emit directories during the listing only if they are explicitly configured in `-listing` ([#3673](#3673)).
 * Exporter: export libraries specified as `requirements.txt` ([#3649](#3649)).
 * Exporter: fix generation of `run_as` blocks in `databricks_job` ([#3724](#3724)).
 * Exporter: use Go SDK structs for `databricks_job` resource ([#3727](#3727)).
 * Fix invalid priviledges in grants.md ([#3716](#3716)).
 * Make the schedule.pause_status field read-only ([#3692](#3692)).
 * Refactored `databricks_cluster(s)` data sources to Go SDK ([#3685](#3685)).
 * Renamed `databricks_catalog_workspace_binding` to `databricks_workspace_binding` ([#3703](#3703)).
 * Run goreleaser action in snapshot mode from merge queue ([#3646](#3646)).
 * Update cluster.md: add data_security_mode parameters `NONE` and `NO_ISOLATION` ([#3740](#3740)).
 * Upgrade databricks-sdk-go ([#3743](#3743)).
 * remove references to basic auth ([#3720](#3720)).
@tanmay-db tanmay-db mentioned this pull request Jul 9, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 19, 2024
@tanmay-db
[Release] v1.49.0 (#3752)
733c998 
## 1.49.0

### New Features and Improvements
* Added `databricks_dashboard` resource
([#3729](#3729)).
* Added `databricks_schema` data source
([#3732](#3732)).
* Added support for binding storage credentials and external locations
to specific workspaces
([#3678](#3678)).
* Added `databricks_volume` as data source
([#3211](#3211)).
* Make the `schedule.pause_status` field read-only
([#3692](#3692)).
* Renamed `databricks_catalog_workspace_binding` to
`databricks_workspace_binding`
([#3703](#3703)).
* Make `cluster_name_contains` optional in `databricks_clusters` data
source
([#3760](#3760)).
* Tolerate OAuth errors in databricks_mws_workspaces when managing
tokens
([#3761](#3761)).
* Permissions for `databricks_dashboard` resource
([#3762](#3762)).

### Exporter
* Emit directories during the listing only if they are explicitly
configured in `-listing`
([#3673](#3673)).
* Export libraries specified as `requirements.txt`
([#3649](#3649)).
* Fix generation of `run_as` blocks in `databricks_job`
([#3724](#3724)).
* Use Go SDK structs for `databricks_job` resource
([#3727](#3727)).
* Clarify use of `-listing` and `-services` options
([#3755](#3755)).
* Improve code generation for SQL Endpoints
([#3764](#3764))

### Documentation
* Fix invalid priviledges in grants.md
([#3716](#3716)).
* Update cluster.md: add data_security_mode parameters `NONE` and
`NO_ISOLATION`
([#3740](#3740)).
* Remove references to basic auth
([#3720](#3720)).
* Update resources diagram
([#3765](#3765)).

### Internal Changes
* Add Release tag
([#3748](#3748)).
* Improve Changelog by grouping changes
([#3747](#3747)).
* Change TF registry ownership
([#3736](#3736)).
* Refactored `databricks_cluster(s)` data sources to Go SDK
([#3685](#3685)).
* Upgrade databricks-sdk-go
([#3743](#3743)).
* Run goreleaser action in snapshot mode from merge queue
([#3646](#3646)).
* Make `dashboard_name` random in integration tests for
`databricks_dashboard` resource
([#3763](#3763)).
* Clear stale go.sum values
([#3768](#3768)).
* Add "Owner" tag to test cluster in acceptance test
([#3771](#3771)).
* Fix integration test for restrict workspace admins setting
([#3772](#3772)).
* Add "Owner" tag to test SQL endpoint in acceptance test
([#3774](#3774)).
* Move PR message validation to a separate workflow
([#3777](#3777)).
* Trigger the validate workflow in the merge queue
([#3782](#3782)).
* Update properties for managed SQL table on latest DBR
([#3784](#3784)).
* Add "Owner" tag to test SQL endpoint in acceptance test
([#3785](#3785)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkvuong nkvuong nkvuong approved these changes

@mgyucht mgyucht Awaiting requested review from mgyucht mgyucht is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

Assignees
No one assigned
Labels
exporter TF configuration generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexott @codecov-commenter @nkvuong