Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add terraform support for periodic triggers #3700

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Add terraform support for periodic triggers #3700

merged 3 commits into from
Jun 28, 2024

Conversation

alexmos-db
Copy link
Contributor

@alexmos-db alexmos-db commented Jun 25, 2024 •
edited
Loading

Changes

  • Add terraform support for periodic trigger for workflows.

Tests

  • New test added to validate periodic triggers.

  • make test run locally

  • relevant change in docs/ folder

  • covered with integration tests in internal/acceptance

  • relevant acceptance tests are passing

➜  terraform-provider-databricks git:(periodic_triggers) ✗ CLOUD_ENV=aws go test -timeout 4800s -run ^TestAccPeriodicTrigger$ github.com/databricks/terraform-provider-databricks/internal/acceptance
ok  	github.com/databricks/terraform-provider-databricks/internal/acceptance	5.003s
  • using Go SDK

@alexmos-db alexmos-db requested review from a team as code owners June 25, 2024 12:31
@alexmos-db alexmos-db requested review from hectorcast-db and removed request for a team June 25, 2024 12:31
@alexmos-db alexmos-db changed the title Add terraform support periodic triggers Add terraform support for periodic triggers Jun 25, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.59%. Comparing base (e300bb9) to head (9bbbd98).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3700      +/-   ##
==========================================
- Coverage   81.60%   81.59%   -0.01%     
==========================================
  Files         196      196              
  Lines       19741    19742       +1     
==========================================
- Hits        16109    16108       -1     
- Misses       2672     2673       +1     
- Partials      960      961       +1
Files Coverage Δ
jobs/resource_job.go 82.38% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

@alexmos-db alexmos-db requested a review from sebastien-db June 28, 2024 13:21
mgyucht
mgyucht approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mgyucht mgyucht added this pull request to the merge queue Jun 28, 2024
Merged via the queue into databricks:main with commit 03c71d0 Jun 28, 2024
5 checks passed
hectorcast-db added a commit that referenced this pull request Jun 28, 2024
@hectorcast-db
Release v1.48.2
29722da 
### New Features and Improvements
* Added isolation mode support for `databricks_external_location` & `databricks_storage_credential` ([#3704](#3704)).
* Add terraform support for periodic triggers ([#3700](#3700)).
@hectorcast-db hectorcast-db mentioned this pull request Jun 28, 2024
Merged
hectorcast-db added a commit that referenced this pull request Jun 28, 2024
@hectorcast-db
Release v1.48.2
31eeb07 
* Added isolation mode support for `databricks_external_location` & `databricks_storage_credential` ([#3704](#3704)).
* Add terraform support for periodic triggers ([#3700](#3700)).
hectorcast-db added a commit that referenced this pull request Jun 28, 2024
@hectorcast-db
Release v1.48.2
0a0c8b4 
* Added isolation mode support for `databricks_external_location` & `databricks_storage_credential` ([#3704](#3704)).
* Add terraform support for periodic triggers ([#3700](#3700)).
hectorcast-db added a commit that referenced this pull request Jun 28, 2024
@hectorcast-db
Release v1.48.2
5a0891b 
* Added isolation mode support for `databricks_external_location` & `databricks_storage_credential` ([#3704](#3704)).
* Add terraform support for periodic triggers ([#3700](#3700)).
github-merge-queue bot pushed a commit that referenced this pull request Jun 28, 2024
@hectorcast-db
Release v1.48.2 (#3722)
f42e1fb 
* Added isolation mode support for `databricks_external_location` & `databricks_storage_credential` ([#3704](#3704)).
* Add terraform support for periodic triggers ([#3700](#3700)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastien-db sebastien-db sebastien-db approved these changes

@mgyucht mgyucht mgyucht approved these changes

@hectorcast-db hectorcast-db Awaiting requested review from hectorcast-db hectorcast-db is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexmos-db @codecov-commenter @mgyucht @sebastien-db