Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added isolation mode support for databricks_external_location & databricks_storage_credential #3704

Merged
merged 3 commits into from
Jun 28, 2024
Merged

added isolation mode support for databricks_external_location & databricks_storage_credential #3704

merged 3 commits into from
Jun 28, 2024

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Jun 25, 2024 •
edited
Loading

Changes

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@nkvuong nkvuong requested review from a team as code owners June 25, 2024 13:49
@nkvuong nkvuong requested review from hectorcast-db and removed request for a team June 25, 2024 13:49
@nkvuong nkvuong mentioned this pull request Jun 25, 2024
Merged
5 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.65%. Comparing base (c976219) to head (cff628b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3704   +/-   ##
=======================================
  Coverage   81.65%   81.65%           
=======================================
  Files         197      197           
  Lines       19731    19729    -2     
=======================================
- Hits        16111    16110    -1     
+ Misses       2660     2659    -1     
  Partials      960      960
Files Coverage Δ
catalog/resource_catalog.go 76.57% <ø> (+0.47%) ⬆️
catalog/resource_external_location.go 78.26% <100.00%> (ø)
catalog/resource_storage_credential.go 61.01% <75.00%> (ø)

@nkvuong nkvuong requested review from edwardfeng-db and removed request for hectorcast-db June 25, 2024 15:09
@nkvuong
Copy link
Contributor Author

nkvuong commented Jun 25, 2024

integration tests passed (failed tests are unrelated)

@nkvuong nkvuong added this pull request to the merge queue Jun 28, 2024
Merged via the queue into main with commit 483eb99 Jun 28, 2024
5 checks passed
@nkvuong nkvuong deleted the feature/isolation_mode branch June 28, 2024 13:25
hectorcast-db added a commit that referenced this pull request Jun 28, 2024
@hectorcast-db
Release v1.48.2
29722da 
### New Features and Improvements
* Added isolation mode support for `databricks_external_location` & `databricks_storage_credential` ([#3704](#3704)).
* Add terraform support for periodic triggers ([#3700](#3700)).
@hectorcast-db hectorcast-db mentioned this pull request Jun 28, 2024
Merged
hectorcast-db added a commit that referenced this pull request Jun 28, 2024
@hectorcast-db
Release v1.48.2
31eeb07 
* Added isolation mode support for `databricks_external_location` & `databricks_storage_credential` ([#3704](#3704)).
* Add terraform support for periodic triggers ([#3700](#3700)).
hectorcast-db added a commit that referenced this pull request Jun 28, 2024
@hectorcast-db
Release v1.48.2
0a0c8b4 
* Added isolation mode support for `databricks_external_location` & `databricks_storage_credential` ([#3704](#3704)).
* Add terraform support for periodic triggers ([#3700](#3700)).
hectorcast-db added a commit that referenced this pull request Jun 28, 2024
@hectorcast-db
Release v1.48.2
5a0891b 
* Added isolation mode support for `databricks_external_location` & `databricks_storage_credential` ([#3704](#3704)).
* Add terraform support for periodic triggers ([#3700](#3700)).
github-merge-queue bot pushed a commit that referenced this pull request Jun 28, 2024
@hectorcast-db
Release v1.48.2 (#3722)
f42e1fb 
* Added isolation mode support for `databricks_external_location` & `databricks_storage_credential` ([#3704](#3704)).
* Add terraform support for periodic triggers ([#3700](#3700)).
@matthewchoy-envisso matthewchoy-envisso mentioned this pull request Jul 10, 2024
Closed
@alexott alexott mentioned this pull request Jul 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardfeng-db edwardfeng-db edwardfeng-db approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkvuong @codecov-commenter @edwardfeng-db