Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated databricks_cluster_policy documentation #3707

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Jun 25, 2024

@nkvuong nkvuong requested review from a team as code owners June 25, 2024 21:45
@nkvuong nkvuong requested review from tanmay-db and removed request for a team June 25, 2024 21:45
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.65%. Comparing base (c976219) to head (92565a6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3707   +/-   ##
=======================================
  Coverage   81.65%   81.65%           
=======================================
  Files         197      197           
  Lines       19731    19731           
=======================================
  Hits        16111    16111           
  Misses       2660     2660           
  Partials      960      960           

see 2 files with indirect coverage changes

@nkvuong nkvuong requested review from edwardfeng-db and removed request for tanmay-db June 26, 2024 08:29
Copy link
Contributor

@edwardfeng-db edwardfeng-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, do we wanna apply some alias as well?

@nkvuong
Copy link
Contributor Author

nkvuong commented Jun 26, 2024

@edwardfeng-db aliasing will be a breaking change, so we need to plan that more carefully. I've filed a separate issue so we don't lose it

@nkvuong nkvuong added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit 505a451 Jun 26, 2024
5 checks passed
@nkvuong nkvuong deleted the doc/cluster_policy branch June 26, 2024 09:55
hectorcast-db added a commit that referenced this pull request Jun 27, 2024
### New Features and Improvements
* Fixed case sensitivity for principals in `databricks_grants` and `databricks_grant` ([#3708](#3708)).

### Documentation Changes
* Update cluster policy doc ([#3707](#3707)).

### Internal Changes
* Refactor some common functions for workspace bindings ([#3702](#3702)).
@hectorcast-db hectorcast-db mentioned this pull request Jun 27, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 27, 2024
### New Features and Improvements
* Fixed case sensitivity for principals in `databricks_grants` and `databricks_grant` ([#3708](#3708)).

### Documentation Changes
* Update cluster policy doc ([#3707](#3707)).

### Internal Changes
* Refactor some common functions for workspace bindings ([#3702](#3702)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants