Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tfsdk <> gosdk structs converter functions and tests #3738

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Add tfsdk <> gosdk structs converter functions and tests #3738

merged 1 commit into from
Jul 9, 2024

Conversation

edwardfeng-db
Copy link
Contributor

@edwardfeng-db edwardfeng-db commented Jul 4, 2024 •
edited
Loading

Changes

image As illustrated in the diagram, we need converter function between tfsdk and gosdk structs to support the plugin framework migration

This PR adds converter functions as well as related unit tests

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

parthban-db
parthban-db reviewed Jul 5, 2024
View reviewed changes
common/reflect_resource_plugin_framework.go Outdated Show resolved Hide resolved
common/reflect_resource_plugin_framework_test.go Outdated Show resolved Hide resolved
common/reflect_resource_plugin_framework.go Outdated Show resolved Hide resolved
@edwardfeng-db edwardfeng-db requested a review from parthban-db July 5, 2024 11:35
parthban-db
parthban-db approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@parthban-db parthban-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edwardfeng-db edwardfeng-db force-pushed the edwardfeng-db/converter-function branch from 96b4abd to 315ac32 Compare July 9, 2024 20:51
@edwardfeng-db edwardfeng-db marked this pull request as ready for review July 9, 2024 20:52
@edwardfeng-db edwardfeng-db requested review from a team as code owners July 9, 2024 20:52
@edwardfeng-db edwardfeng-db merged commit 60f0597 into terraform-plugin-framework Jul 9, 2024
3 checks passed
@edwardfeng-db edwardfeng-db deleted the edwardfeng-db/converter-function branch July 9, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthban-db parthban-db parthban-db approved these changes

@tanmay-db tanmay-db Awaiting requested review from tanmay-db

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwardfeng-db @parthban-db