[Internal] Bumped terraform-plugin-framework branch to latest main
#3780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tabricks_storage_credential` (#3704) * add isolation mode support for external location & storage credential * add doc & test
* Add periodic triggers * Add acceptance test for periodic triggers * Fix typo
Bumps [github.com/hashicorp/hcl/v2](https://github.com/hashicorp/hcl) from 2.20.1 to 2.21.0. - [Release notes](https://github.com/hashicorp/hcl/releases) - [Changelog](https://github.com/hashicorp/hcl/blob/main/CHANGELOG.md) - [Commits](hashicorp/hcl@v2.20.1...v2.21.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/hcl/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* relax cluster check * fix * fix * refactor `databricks_cluster` data source to Go SDK * refactor `databricks_clusters` data source to Go SDK
…ce_binding` (#3703) * rename resource * fix test
* Exporter: fix generation of `run_as` blocks in `databricks_job` Because the `run_as` was marked as `computed` it was ignored when generating the code. * Ignore `run_as` for the current user
* data_volume * data_volume unit and acceptance tests * docs * WorkspaceDataWithCustomParams test * fixed formatting * Removing unnecessary changes to resource.go * refactored data_volume * making change for consitency with GO SDK v0.35.0 * Update catalog/data_volume.go * Update catalog/data_volume.go * data source as nested strucutre * review comments addressed * acceptance test --------- Co-authored-by: Alex Ott <alexey.ott@databricks.com> Co-authored-by: vuong-nguyen <44292934+nkvuong@users.noreply.github.com>
…to specific workspaces (#3678) * add isolation mode * rename * doc * fix doc * add tests * add acceptance tests * add computed * typo * add tests * use correct isolation_mode * fix test
* Run goreleaser action in snapshot mode from merge queue * Don't run on PRs * False branch
Bumps [golang.org/x/mod](https://github.com/golang/mod) from 0.18.0 to 0.19.0. - [Commits](golang/mod@v0.18.0...v0.19.0) --- updated-dependencies: - dependency-name: golang.org/x/mod dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…SOLATION` (#3740) * Update cluster.md * Update cluster.md
Adding new data source for completeness of our data sources for UC objects.
…itly configured in `-listing` (#3673) Exporter emitted directories even if they were specified only in `-services`, leading to exporting of not necessary objects...
* [Internal] Improve Changelog by grouping changes * Fixes
* Lakeview dashboard resource created * restructured the lakeview dashboard code * restructured integration tests for lakeview dashboards * added file read function in common/util.go * Refactored the code of lakeview dashboard * rectified mistakes in integration tests and documentation * added some function in util.go * Update dashboards/resource_lakeview_dashboard.go Co-authored-by: vuong-nguyen <44292934+nkvuong@users.noreply.github.com> * changed name of resource from lakeview_dashboard to dashboard and modified schema * Modified unit test for dashboard resource * added tests for helper functions in util.go * [Fix] fixed the docs and unit tests for dashboard resource --------- Co-authored-by: vuong-nguyen <44292934+nkvuong@users.noreply.github.com>
* Lakeview dashboard resource created * restructured the lakeview dashboard code * restructured integration tests for lakeview dashboards * added file read function in common/util.go * Refactored the code of lakeview dashboard * rectified mistakes in integration tests and documentation * added some function in util.go * Update dashboards/resource_lakeview_dashboard.go Co-authored-by: vuong-nguyen <44292934+nkvuong@users.noreply.github.com> * changed name of resource from lakeview_dashboard to dashboard and modified schema * Modified unit test for dashboard resource * added tests for helper functions in util.go * [Fix] fixed the docs and unit tests for dashboard resource * made dashboard name random in integration tests for dashboard resource --------- Co-authored-by: vuong-nguyen <44292934+nkvuong@users.noreply.github.com>
…ing tokens (#3761) * work * fmt * tested * remove test * add integration test
This PR adds support for setting permissions on Lakeview dashboards. The nature of API requires introduction of resource-specific code inside the permissions resource: * The object type `dashboard` is the same for legacy and Lakeview dashboards, so we need to check object ID to distinguish between them. * In contrast to other resources, the `object_id` returned by API isn't the ID of the dashboard itself, but object ID of file on WSFS. Co-authored-by: Divyansh Vijayvergia <171924202+Divyansh-db@users.noreply.github.com>
This ensures proper attribution in our test infrastructure.
This test requires the authenticated user to be an account administrator. Our non-UC test environments don't use identity federation and are therefore by definition not account admins. Require a UC test environment to get around this limitation.
This ensures proper attribution in our test infrastructure. The same fix for clusters was applied in #3771.
## Changes Move PR message validation to a separate workflow ## Tests Updated title for this PR
## Changes <!-- Summary of your changes that are easy to understand --> Changes include: - Always generate `enable_serverless_compute` attribute for `databricks_sql_endpoint` and `databricks_sql_global_config` - this is required when there is a mix of serverless & non-serverless SQL endpoints - Don't generate `channel` when it's empty or is current - Don't generate `tags` block when there are no tags - Importable can define `ShouldGenerateField` function to specify if the code for a field should be generated even if it's `omitempty` and having the zero or default value. This was required for generation of `enable_serverless_compute = false` that is marked as `omitempty` Fixes #3758 ## Tests <!-- How is this tested? Please see the checklist below and also describe any other relevant tests --> - [x] `make test` run locally - [ ] relevant change in `docs/` folder - [ ] covered with integration tests in `internal/acceptance` - [ ] relevant acceptance tests are passing - [ ] using Go SDK
tanmay-db
changed the title
terraform-plugin-framework branch to latest main
tanmay-db
changed the title
terraform-plugin-framework branch to latest mainterraform-plugin-framework branch to latest main
5 tasks
edwardfeng-db
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Rebase the Plugin Framework branch to latest main + resolve conflicts: 9e8fd30
This needs to be merged before #3719 can be merged. Rebasing the PR over main will lead to many commits/changes so separating them in this PR.
Tests
Unit tests
make testrun locallydocs/folderinternal/acceptance