Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal] Rollout Plugin Framework #4134

Merged
merged 3 commits into from
Nov 1, 2024
Merged

[Internal] Rollout Plugin Framework #4134

merged 3 commits into from
Nov 1, 2024

Conversation

edwardfeng-db
Copy link
Contributor

@edwardfeng-db edwardfeng-db commented Oct 22, 2024 •
edited
Loading

Changes

  • Made it possible to use environment variable USE_SDK_V2 to control rollout
  • Bumped resource and data source names from staging names to production names (can debate on whether we want to do that now or in a more gradual fashion)
  • Proposed mechanism: https://docs.google.com/document/d/1zfTp8YesMe4GxkbIt9Sbwd5nQL7Y4mXed8dPDGmAoxU/edit?tab=t.0
  • Added infra for switching providers from sdkv2 to plugin framework in integration tests and added test cases for those cases

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@edwardfeng-db edwardfeng-db requested review from a team as code owners October 22, 2024 03:50
@edwardfeng-db edwardfeng-db requested review from mgyucht and removed request for a team October 22, 2024 03:50
@edwardfeng-db edwardfeng-db force-pushed the jinghao-feng_data/rollout-pfw branch from 6c5a274 to 5aa1320 Compare October 22, 2024 03:52
edwardfeng-db
edwardfeng-db commented Oct 23, 2024
View reviewed changes
internal/providers/pluginfw/resources/library/resource_library_acc_test.go
}

// Testing the transition from plugin framework to sdkv2.
func TestAccLibraryUpdateTransitionFromPluginFw(t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can create a helper function for these transition test cases

@edwardfeng-db edwardfeng-db force-pushed the jinghao-feng_data/rollout-pfw branch from 27915a3 to 905e68f Compare October 23, 2024 21:28
mgyucht
mgyucht approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval pending the suggested changes.

docs/data-sources/volumes.md Outdated Show resolved Hide resolved
internal/providers/pluginfw/pluginfw_rollout_utils.go Outdated Show resolved Hide resolved
internal/providers/pluginfw/pluginfw_rollout_utils.go Outdated Show resolved Hide resolved
internal/providers/pluginfw/pluginfw_rollout_utils.go Outdated Show resolved Hide resolved
internal/providers/pluginfw/pluginfw_rollout_utils.go Outdated Show resolved Hide resolved
internal/providers/pluginfw/pluginfw_rollout_utils.go Outdated Show resolved Hide resolved
internal/providers/providers.go Outdated Show resolved Hide resolved
internal/providers/pluginfw/resources/library/resource_library_acc_test.go Outdated Show resolved Hide resolved
internal/providers/pluginfw/resources/qualitymonitor/resource_quality_monitor_acc_test.go Outdated Show resolved Hide resolved
internal/providers/sdkv2/sdkv2.go
}

// Remove the resources and data sources that are being migrated to plugin framework
for _, dataSourceToRemove := range pluginfw.GetSdkV2DataSourcesToRemove(sdkV2Fallbacks...) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should panic if dataSourceToRemove is not in dataSourceMap. Ditto for resourceMap.

@edwardfeng-db edwardfeng-db force-pushed the jinghao-feng_data/rollout-pfw branch from be24f8a to d7cbde6 Compare October 31, 2024 00:05
@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/11622757764

@edwardfeng-db edwardfeng-db added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit da1f7e4 Nov 1, 2024
12 checks passed
@edwardfeng-db edwardfeng-db deleted the jinghao-feng_data/rollout-pfw branch November 1, 2024 03:54
tanmay-db added a commit that referenced this pull request Nov 5, 2024
@tanmay-db
[Release] Release v1.57.0
d56fe61 
### New Features and Improvements

 * Added `databricks_functions` data source ([#4154](#4154)).

### Bug Fixes

 * Handle edge case for `effective_properties` in `databricks_sql_table` ([#4153](#4153)).
 * Provide more prescriptive error when users fail to create a single node cluster ([#4168](#4168)).

### Internal Changes

 * Add test instructions for external contributors ([#4169](#4169)).
 * Always write message for manual test integration ([#4188](#4188)).
 * Make `Read` after `Create`/`Update` configurable ([#4190](#4190)).
 * Migrate Share Data Source to Plugin Framework ([#4161](#4161)).
 * Migrate Share Resource to Plugin Framework ([#4047](#4047)).
 * Rollout Plugin Framework  ([#4134](#4134)).

### Dependency Updates

 * Bump Go SDK to v0.50.0 ([#4178](#4178)).

### Exporter

 * Allow to match resource names by regular expression ([#4177](#4177)).
@tanmay-db tanmay-db mentioned this pull request Nov 5, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 6, 2024
@tanmay-db
[Release] Release v1.57.0 (#4193)
f381fbf 
### New Features and Improvements

* Added `databricks_functions` data source
([#4154](#4154)).


### Bug Fixes

* Handle edge case for `effective_properties` in `databricks_sql_table`
([#4153](#4153)).
* Provide more prescriptive error when users fail to create a single
node cluster
([#4168](#4168)).


### Internal Changes

* Add test instructions for external contributors
([#4169](#4169)).
* Always write message for manual test integration
([#4188](#4188)).
* Make `Read` after `Create`/`Update` configurable
([#4190](#4190)).
* Migrate Share Data Source to Plugin Framework
([#4161](#4161)).
* Migrate Share Resource to Plugin Framework
([#4047](#4047)).
* Rollout Plugin Framework
([#4134](#4134)).


### Dependency Updates

* Bump Go SDK to v0.50.0
([#4178](#4178)).


### Exporter

* Allow to match resource names by regular expression
([#4177](#4177)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgyucht mgyucht mgyucht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edwardfeng-db @eng-dev-ecosystem-bot @mgyucht